Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: src/mainboard/supermicro/x11-lga1151v2-series: Add Support for X11SCH-F ......................................................................
Patch Set 51:
(4 comments)
H
https://review.coreboot.org/c/coreboot/+/37441/51/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37441/51/src/mainboard/supermicro/x... PS51, Line 31: 1000 There's a Kconfig for that now.
https://review.coreboot.org/c/coreboot/+/37441/51/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37441/51/src/mainboard/supermicro/x... PS51, Line 38: . Use_espi=1?
https://review.coreboot.org/c/coreboot/+/37441/49/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/37441/49/src/mainboard/supermicro/x... PS49, Line 18: params->PchHdaVcType = 0x1;
Make this common then?
That was a workaround for KBL. I don't think this should be here.
https://review.coreboot.org/c/coreboot/+/37441/49/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/romstage.c:
https://review.coreboot.org/c/coreboot/+/37441/49/src/mainboard/supermicro/x... PS49, Line 6: console Not needed