Attention is currently required from: Johnny Lin, Angel Pons, Shuming Chu (Shuming), Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69198 )
Change subject: include/cper.h: Add CPER Memory Error Section definitions
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
File src/include/cper.h:
https://review.coreboot.org/c/coreboot/+/69198/comment/8b5b143b_ae3e3646
PS3, Line 400: enum cper_err_code mem_err_type;
Will this work properly? Not sure if the size of enum types is well-defined.
It won't. This needs to be u8 according to the spec. sizeof(enum) == sizeof(int).
https://review.coreboot.org/c/coreboot/+/69198/comment/6aefb1af_fa959efd
PS3, Line 405: __packed
This is not needed. All entries seem aligned.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a165350a16a4cbe4033a3e7c43fa23a5b27c44b
Gerrit-Change-Number: 69198
Gerrit-PatchSet: 3
Gerrit-Owner: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sat, 12 Nov 2022 07:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment