HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36262 )
Change subject: (acpi) superio.asl: Drop wrong _ADR objects ......................................................................
(acpi) superio.asl: Drop wrong _ADR objects
Use a _HID but not _HID and _ADR at teh same time.
Found-by: ACPICA 20191018 Change-Id: Ic0bcaa37ac017ab61e1fb4e78d3c7dfbbcc0899d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/google/chromeec/acpi/superio.asl M src/ec/google/wilco/acpi/superio.asl M src/mainboard/facebook/fbg1701/acpi/superio.asl M src/mainboard/portwell/m107/acpi/superio.asl 4 files changed, 0 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/36262/1
diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl index c521a3a..9c0fa68 100644 --- a/src/ec/google/chromeec/acpi/superio.asl +++ b/src/ec/google/chromeec/acpi/superio.asl @@ -40,7 +40,6 @@ Device (ECMM) { Name (_HID, EISAID ("PNP0C02")) Name (_UID, 4) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -64,7 +63,6 @@ Device (ECUI) { Name (_HID, EISAID ("PNP0C02")) Name (_UID, 3) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -109,7 +107,6 @@ Device (COM1) { Name (_HID, EISAID ("PNP0501")) Name (_UID, 1) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -137,7 +134,6 @@ Device (PS2K) // Keyboard { Name (_UID, 0) - Name (_ADR, 0) Name (_HID, "GOOG000A") Name (_CID, Package() { EISAID("PNP0303"), EISAID("PNP030B") } )
diff --git a/src/ec/google/wilco/acpi/superio.asl b/src/ec/google/wilco/acpi/superio.asl index 0995d6a..42575bd 100644 --- a/src/ec/google/wilco/acpi/superio.asl +++ b/src/ec/google/wilco/acpi/superio.asl @@ -25,7 +25,6 @@ { Name (_HID, EisaId ("PNP0501")) Name (_UID, 1) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { @@ -57,7 +56,6 @@ Name (_HID, EisaId ("PNP0303")) Name (_CID, EisaId ("PNP030B")) Name (_UID, 0) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { @@ -90,7 +88,6 @@ { Name (_HID, EisaId ("PNP0F13")) Name (_UID, 0) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { diff --git a/src/mainboard/facebook/fbg1701/acpi/superio.asl b/src/mainboard/facebook/fbg1701/acpi/superio.asl index 468c95c..bdaa912 100644 --- a/src/mainboard/facebook/fbg1701/acpi/superio.asl +++ b/src/mainboard/facebook/fbg1701/acpi/superio.asl @@ -21,7 +21,6 @@ Device (COM1) { Name (_HID, EISAID ("PNP0501")) Name (_UID, 1) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { diff --git a/src/mainboard/portwell/m107/acpi/superio.asl b/src/mainboard/portwell/m107/acpi/superio.asl index 0258e28..e411f72 100644 --- a/src/mainboard/portwell/m107/acpi/superio.asl +++ b/src/mainboard/portwell/m107/acpi/superio.asl @@ -21,7 +21,6 @@ Device (COM1) { Name (_HID, EISAID ("PNP0501")) Name (_UID, 1) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) {
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36262 )
Change subject: (acpi) superio.asl: Drop wrong _ADR objects ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36262/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36262/1//COMMIT_MSG@9 PS1, Line 9: Use a _HID but not _HID and _ADR at teh same time. the
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36262
to look at the new patch set (#3).
Change subject: (acpi) superio.asl: Drop wrong _ADR objects ......................................................................
(acpi) superio.asl: Drop wrong _ADR objects
Use _HID but not _HID and _ADR at the same time.
Found-by: ACPICA 20191018 Change-Id: Ic0bcaa37ac017ab61e1fb4e78d3c7dfbbcc0899d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/google/wilco/acpi/superio.asl M src/mainboard/facebook/fbg1701/acpi/superio.asl M src/mainboard/portwell/m107/acpi/superio.asl 3 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/36262/3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36262 )
Change subject: (acpi) superio.asl: Drop wrong _ADR objects ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36262/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36262/1//COMMIT_MSG@9 PS1, Line 9: Use a _HID but not _HID and _ADR at teh same time.
the
Oops :) Thank you
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36262 )
Change subject: (acpi) superio.asl: Drop wrong _ADR objects ......................................................................
Patch Set 3: Code-Review+2
Works fine on facebook fbg1701
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36262
to look at the new patch set (#4).
Change subject: (acpi) superio.asl: Drop wrong _ADR objects ......................................................................
(acpi) superio.asl: Drop wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Found-by: ACPICA 20191018 Change-Id: Ic0bcaa37ac017ab61e1fb4e78d3c7dfbbcc0899d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/google/wilco/acpi/superio.asl M src/mainboard/facebook/fbg1701/acpi/superio.asl M src/mainboard/portwell/m107/acpi/superio.asl 3 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/36262/4
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36262 )
Change subject: (acpi) superio.asl: Drop wrong _ADR objects ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36262/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36262/1//COMMIT_MSG@9 PS1, Line 9: Use a _HID but not _HID and _ADR at teh same time.
Oops :) […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36262 )
Change subject: (acpi) superio.asl: Drop wrong _ADR objects ......................................................................
(acpi) superio.asl: Drop wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Found-by: ACPICA 20191018 Change-Id: Ic0bcaa37ac017ab61e1fb4e78d3c7dfbbcc0899d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36262 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/ec/google/wilco/acpi/superio.asl M src/mainboard/facebook/fbg1701/acpi/superio.asl M src/mainboard/portwell/m107/acpi/superio.asl 3 files changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/ec/google/wilco/acpi/superio.asl b/src/ec/google/wilco/acpi/superio.asl index 0995d6a..42575bd 100644 --- a/src/ec/google/wilco/acpi/superio.asl +++ b/src/ec/google/wilco/acpi/superio.asl @@ -25,7 +25,6 @@ { Name (_HID, EisaId ("PNP0501")) Name (_UID, 1) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { @@ -57,7 +56,6 @@ Name (_HID, EisaId ("PNP0303")) Name (_CID, EisaId ("PNP030B")) Name (_UID, 0) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { @@ -90,7 +88,6 @@ { Name (_HID, EisaId ("PNP0F13")) Name (_UID, 0) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { diff --git a/src/mainboard/facebook/fbg1701/acpi/superio.asl b/src/mainboard/facebook/fbg1701/acpi/superio.asl index 468c95c..bdaa912 100644 --- a/src/mainboard/facebook/fbg1701/acpi/superio.asl +++ b/src/mainboard/facebook/fbg1701/acpi/superio.asl @@ -21,7 +21,6 @@ Device (COM1) { Name (_HID, EISAID ("PNP0501")) Name (_UID, 1) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) { diff --git a/src/mainboard/portwell/m107/acpi/superio.asl b/src/mainboard/portwell/m107/acpi/superio.asl index 0258e28..e411f72 100644 --- a/src/mainboard/portwell/m107/acpi/superio.asl +++ b/src/mainboard/portwell/m107/acpi/superio.asl @@ -21,7 +21,6 @@ Device (COM1) { Name (_HID, EISAID ("PNP0501")) Name (_UID, 1) - Name (_ADR, 0)
Method (_STA, 0, NotSerialized) {
-
Frans Hendriks (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)