Attention is currently required from: Felix Held, Jason Glenesk, Matt DeVillier.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76165?usp=email )
Change subject: soc/amd/phoenix: Remove TODO after review
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/phoenix/Kconfig:
https://review.coreboot.org/c/coreboot/+/76165/comment/6b7e0e21_f6fbc865 :
PS1, Line 40: # TODO: Check if this is still correct
this one can go as well
Acknowledged - also included SOC_AMD_COMMON_FSP_CCX_CPPC_HOB after testing
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76165?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd2b53ff24776238190eb946db7b12827fcfc804
Gerrit-Change-Number: 76165
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 30 Jun 2023 11:57:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-MessageType: comment