Attention is currently required from: Patrick Rudolph, Shuo Liu.
Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/84425?usp=email )
Change subject: drivers/aspeed/common: Add AST2600 support ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/drivers/aspeed/common/ast_main.c:
https://review.coreboot.org/c/coreboot/+/84425/comment/8cabccb9_3a7860b1?usp... : PS2, Line 200: AST2500 This change shouldn't matter when adding support for the AST2600
File src/drivers/aspeed/common/ast_mode.c:
https://review.coreboot.org/c/coreboot/+/84425/comment/48391565_783fb7cf?usp... : PS2, Line 295: ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xFC, 0xFD, 0x00); Does this need to be done on non-AST2600 chips?