Attention is currently required from: Anil Kumar K, Bora Guvendik, Martin L Roth, Subrata Banik, Wonkyu Kim.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84107?usp=email )
Change subject: payloads/depthcharge: Add default 64-bit libpayload config
......................................................................
Patch Set 4:
(2 comments)
File payloads/external/depthcharge/Kconfig:
https://review.coreboot.org/c/coreboot/+/84107/comment/4a6f79a4_c2d92c7e?usp... :
PS4, Line 68: default n if LP_DEFCONFIG_OVERRIDE
I don't believe you need this line. […]
Done
https://review.coreboot.org/c/coreboot/+/84107/comment/5a4c88ab_82e138ad?usp... :
PS4, Line 70: The Depthcharge makefile looks for a file config.<boardname> in the
: libpayload/configs directory. Say Y here to use the file defconfig
: instead. This is can be a convenience for development purposes, or
: if the defaults in defconfig are sufficient for your system.
this should somehow convey that one needs to select this config to boot a 64-bit payload
sure. updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84107?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac07cf9e3c11e49955c69553407be76ef4f8c060
Gerrit-Change-Number: 84107
Gerrit-PatchSet: 4
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Wed, 28 Aug 2024 17:31:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com