Attention is currently required from: Felix Singer, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Andrey Petrov, Patrick Rudolph, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60402 )
Change subject: drivers/intel/fsp2_0: Make FSP Notify Phase APIs optional ......................................................................
Patch Set 6: Code-Review+1
(2 comments)
File src/drivers/intel/fsp2_0/notify.c:
https://review.coreboot.org/c/coreboot/+/60402/comment/4cad9c19_1d759f71 PS6, Line 12: if (phase == AFTER_PCI_ENUM && CONFIG(SKIP_FSP_NOTIFY_PHASE_AFTER_PCI_ENUM)) : return false; : else if (phase == READY_TO_BOOT && CONFIG(SKIP_FSP_NOTIFY_PHASE_READY_TO_BOOT)) : return false; : else if (phase == END_OF_FIRMWARE && CONFIG(SKIP_FSP_NOTIFY_PHASE_END_OF_FIRMWARE)) : return false; : else : return true; Idea: Use a switch statement?
switch (phase) { case AFTER_PCI_ENUM: return !CONFIG(SKIP_FSP_NOTIFY_PHASE_AFTER_PCI_ENUM); case READY_TO_BOOT: return !CONFIG(SKIP_FSP_NOTIFY_PHASE_READY_TO_BOOT); case END_OF_FIRMWARE: return !CONFIG(SKIP_FSP_NOTIFY_PHASE_END_OF_FIRMWARE); default: return true; }
https://review.coreboot.org/c/coreboot/+/60402/comment/28f7aaf5_fac8f1fe PS6, Line 41: timestamp_add_now(TS_FSP_BEFORE_ENUMERATE); : post_code(POST_FSP_NOTIFY_BEFORE_ENUMERATE); Maybe we could have a struct to store the per-phase information. I'll try to do something.