Change in coreboot[master]: mb/system76/lemp9: update power limits

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jeremy Soller (Code Review)

20 Jul 2020 20 Jul '20

9:32 p.m.

Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43624 )

Change subject: mb/system76/lemp9: update power limits ......................................................................

mb/system76/lemp9: update power limits

Tested on lemp9, power limits are corrected

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/43624/1

diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 27f5efb..3a158ed 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -25,8 +25,8 @@ # CPU (soc/intel/cannonlake/cpu.c) # Power limit register "power_limits_config" = "{ - .tdp_pl1_override = 15, - .tdp_pl2_override = 25, + .tdp_pl1_override = 20, + .tdp_pl2_override = 30, }"

# Enable "Intel Speed Shift Technology"

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Angel Pons (Code Review)

20 Jul 20 Jul

9:40 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43624 )

Change subject: mb/system76/lemp9: update power limits ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43624/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43624/1//COMMIT_MSG@9 PS1, Line 9: Tested on lemp9, power limits are corrected Why were previous power limits wrong? Any references used to determine the correct values?

Jeremy Soller (Code Review)

9:53 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43624

to look at the new patch set (#2).

Change subject: mb/system76/lemp9: update power limits ......................................................................

mb/system76/lemp9: update power limits

Tested on lemp9, power limits are adjusted from the previously low values to the values the thermal system can handle.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/43624/2

Angel Pons (Code Review)

9:59 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43624 )

Change subject: mb/system76/lemp9: update power limits ......................................................................

Patch Set 4: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43624/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43624/1//COMMIT_MSG@9 PS1, Line 9: Tested on lemp9, power limits are corrected

...

Why were previous power limits wrong? Any references used to determine the correct values?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Gerrit-Change-Number: 43624 Gerrit-PatchSet: 4 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 Jul 2020 21:59:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Jeremy Soller (Code Review)

10:02 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43624

to look at the new patch set (#7).

Change subject: mb/system76/lemp9: update power limits ......................................................................

mb/system76/lemp9: update power limits

Tested on lemp9, power limits are adjusted from the previously low values to the values the thermal system can handle.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/43624/7

Jeremy Soller (Code Review)

10:11 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43624

to look at the new patch set (#8).

Change subject: mb/system76/lemp9: update power limits ......................................................................

mb/system76/lemp9: update power limits

Tested on lemp9, power limits are adjusted from the previously low values to the values the thermal system can handle.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/43624/8

Michael Niewöhner (Code Review)

10:21 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43624 )

Change subject: mb/system76/lemp9: update power limits ......................................................................

Patch Set 8: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Gerrit-Change-Number: 43624 Gerrit-PatchSet: 8 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 Jul 2020 22:21:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jeremy Soller (Code Review)

21 Jul 21 Jul

2:20 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43624

to look at the new patch set (#12).

Change subject: mb/system76/lemp9: update power limits ......................................................................

mb/system76/lemp9: update power limits

Tested on lemp9, power limits are adjusted from the previously low values to the values the thermal system can handle.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/43624/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/43624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Gerrit-Change-Number: 43624 Gerrit-PatchSet: 12 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

22 Jul 22 Jul

12:45 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43624

to look at the new patch set (#16).

Change subject: mb/system76/lemp9: update power limits ......................................................................

mb/system76/lemp9: update power limits

Tested on lemp9, power limits are adjusted from the previously low values to the values the thermal system can handle.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/43624/16

-- To view, visit https://review.coreboot.org/c/coreboot/+/43624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Gerrit-Change-Number: 43624 Gerrit-PatchSet: 16 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

2:09 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43624

to look at the new patch set (#18).

Change subject: mb/system76/lemp9: update power limits ......................................................................

mb/system76/lemp9: update power limits

Tested on lemp9, power limits are adjusted from the previously low values to the values the thermal system can handle.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/43624/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/43624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Gerrit-Change-Number: 43624 Gerrit-PatchSet: 18 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

30 Aug 30 Aug

1:19 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43624 )

Change subject: mb/system76/lemp9: update power limits ......................................................................

Patch Set 19:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43624/19//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43624/19//COMMIT_MSG@10 PS19, Line 10: the thermal system can handle I'd like to see some note here how that was tested/determined

-- To view, visit https://review.coreboot.org/c/coreboot/+/43624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Gerrit-Change-Number: 43624 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Comment-Date: Sun, 30 Aug 2020 13:19:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

17 Sep 17 Sep

9:35 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43624

to look at the new patch set (#20).

Change subject: mb/system76/lemp9: update power limits ......................................................................

mb/system76/lemp9: update power limits

Tested on lemp9, power limits are adjusted from the previously low values to the values the thermal system can handle. This was determined by increasing the values and running the system at 100% CPU utilization until thermal throttling occured and the chassis temperature became uncomfortable.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/43624/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/43624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Gerrit-Change-Number: 43624 Gerrit-PatchSet: 20 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

9:36 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43624 )

Change subject: mb/system76/lemp9: update power limits ......................................................................

Patch Set 20: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/43624/19//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43624/19//COMMIT_MSG@10 PS19, Line 10: the thermal system can handle

...

I'd like to see some note here how that was tested/determined

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Gerrit-Change-Number: 43624 Gerrit-PatchSet: 20 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Comment-Date: Thu, 17 Sep 2020 21:36:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

9:37 p.m.

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43624 )

Change subject: mb/system76/lemp9: update power limits ......................................................................

mb/system76/lemp9: update power limits

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Reviewed-on: https://review.coreboot.org/c/coreboot/+/43624 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved

diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 1b11033..e7e68e8 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -25,8 +25,8 @@ # CPU (soc/intel/cannonlake/cpu.c) # Power limit register "power_limits_config" = "{ - .tdp_pl1_override = 15, - .tdp_pl2_override = 25, + .tdp_pl1_override = 20, + .tdp_pl2_override = 30, }"

# Enable "Intel Speed Shift Technology"

-- To view, visit https://review.coreboot.org/c/coreboot/+/43624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Gerrit-Change-Number: 43624 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-MessageType: merged

9elements QA (Code Review)

18 Sep 18 Sep

2:40 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43624 )

Change subject: mb/system76/lemp9: update power limits ......................................................................

Patch Set 21:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19896 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19895 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19894 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19893 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19892 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19900 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19899 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19898 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19897

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/43624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e176e9d98376f8e2dc415e4397efc456869e72d Gerrit-Change-Number: 43624 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Comment-Date: Fri, 18 Sep 2020 02:40:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1340

days inactive

1400

days old

coreboot-gerrit@coreboot.org

14 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
Angel Pons (Code Review)
Jeremy Soller (Code Review)
Michael Niewöhner (Code Review)