Attention is currently required from: SH Kim, Vincent Palatin, Edward Doan, Karthik Ramasubramanian.
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51049 )
Change subject: mb/google/dedede/var/sasuke: Configure GPP_B7 as GPO_HIGH
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51049/comment/aeb6c3ab_9b92829d
PS1, Line 9: Sasuke doesn't have SAR sensor, we
: would keep this signal as high.
Should it still be high. […]
GPO_HIGH config was a suggestion in b:180492044. GPP_B7 is wired to SAR input of LTE modem physically, so discussed about keeping signal to high in the tracker.
I think we can use PAD_NC(GPP_B7, UP_20K) like you said as well, which one is batter?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51049
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib38c649830db2291b3a2a771f5c884acf37dcbeb
Gerrit-Change-Number: 51049
Gerrit-PatchSet: 1
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Edward Doan
edoan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Vincent Palatin
vpalatin@chromium.org
Gerrit-Reviewer: Vincent Palatin
vpalatin@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Vincent Palatin
vpalatin@google.com
Gerrit-Attention: Edward Doan
edoan@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 04 Mar 2021 01:44:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment