Change in coreboot[master]: test/lib: Add non-existent DIMMs test case in spd_cache-test - coreboot-gerrit

16 Apr 2022


      Attention is currently required from: Jakub Czapiga.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63643 )
Change subject: test/lib: Add non-existent DIMMs test case in spd_cache-test
......................................................................
Patch Set 1:
(2 comments)
File tests/lib/spd_cache-test.c:
https://review.coreboot.org/c/coreboot/+/63643/comment/582a06b2_b85ee52c 
PS1, Line 73: 0
I would like to fix this, since in ROM default value is 0xff, you you never access that. In a follow up CL.
https://review.coreboot.org/c/coreboot/+/63643/comment/38a05fcd_f86cdb5b 
PS1, Line 84: 0
same above.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c8aa92ee0cfd5908399f4bbd305f8f306571d40
Gerrit-Change-Number: 63643
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Comment-Date: Sat, 16 Apr 2022 03:59:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment