Change in coreboot[master]: sc7280: Add CPUCP firmware support - coreboot-gerrit

8 Nov 2021


      Attention is currently required from: Ravi kumar.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: Add CPUCP firmware support
......................................................................
Patch Set 86:
(1 comment)
File src/soc/qualcomm/sc7280/include/soc/cpucp.h:
https://review.coreboot.org/c/coreboot/+/49768/comment/1f27b7bb_dd06e960 
PS86, Line 6: #define EPSSTOP_EPSS_TOP (void *)0x18598000
These should go into <soc/addressmap.h> (and we don't usually put the (void *) cast in the macro).
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49768
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idac22c8cb231658616999bc577bdf49f9aa7ae74
Gerrit-Change-Number: 49768
Gerrit-PatchSet: 86
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Comment-Date: Mon, 08 Nov 2021 17:48:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment