Attention is currently required from: David Wu, Karthik Ramasubramanian, Marx Wang, Subrata Banik.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/85580?usp=email )
Change subject: mb/google/brox/var/jubilant: Apply ISH_FW_VERSION in Kconfig
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/85580/comment/1a15374e_e4a8014d?usp... :
PS1, Line 89: select SOC_INTEL_STORE_ISH_FW_VERSION if DRIVERS_INTEL_ISH
do you mind following the alphabetic order ?>
thanks for your remind.
fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85580?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I31db0925a81b6ec68ee6afcb262e540ba7db206a
Gerrit-Change-Number: 85580
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Marx Wang
marx.wang@intel.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 16 Dec 2024 01:23:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com