Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48920 )
Change subject: mb/clevo/n13xwu: Disable GMM PCI device ......................................................................
mb/clevo/n13xwu: Disable GMM PCI device
We don't know exactly for what the GMM PCI device is used for or how it is used. Thus, disable and remove it.
Change-Id: I4b8b33b16527cbcc21168b995cbfdb54a2fa3cac Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/48920/1
diff --git a/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb b/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb index 6a4f97d..808ece0 100644 --- a/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb +++ b/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb @@ -46,7 +46,6 @@ device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device device pci 04.0 on end # SA thermal subsystem - device pci 08.0 on end # Gaussian Mixture Model device pci 14.0 on # USB xHCI register "SsicPortEnable" = "0" # USB2
Hello build bot (Jenkins), Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48920
to look at the new patch set (#2).
Change subject: mb/clevo/n13xwu: Disable GMM PCI device ......................................................................
mb/clevo/n13xwu: Disable GMM PCI device
We don't know exactly for what the GMM PCI device is used for or how it is used. Thus, disable and remove it.
Change-Id: I4b8b33b16527cbcc21168b995cbfdb54a2fa3cac Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/48920/2
Hello build bot (Jenkins), Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48920
to look at the new patch set (#3).
Change subject: mb/clevo/n13xwu: Disable GMM PCI device ......................................................................
mb/clevo/n13xwu: Disable GMM PCI device
We don't know exactly for what the GMM PCI device is used for or how it is used. Thus, disable and remove it.
Change-Id: I4b8b33b16527cbcc21168b995cbfdb54a2fa3cac Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/48920/3
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48920 )
Change subject: mb/clevo/n13xwu: Disable GMM PCI device ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48920/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48920/3//COMMIT_MSG@10 PS3, Line 10: Thus, disable and remove it. remove it to fall back to default-disable or so?
Hello build bot (Jenkins), Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48920
to look at the new patch set (#4).
Change subject: mb/clevo/n13xwu: Disable GMM PCI device ......................................................................
mb/clevo/n13xwu: Disable GMM PCI device
We don't know exactly for what the GMM PCI device is used for or how it is used. Thus, remove it to fallback to default-disable.
Change-Id: I4b8b33b16527cbcc21168b995cbfdb54a2fa3cac Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/48920/4
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48920 )
Change subject: mb/clevo/n13xwu: Disable GMM PCI device ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48920/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48920/3//COMMIT_MSG@10 PS3, Line 10: Thus, disable and remove it.
remove it to fall back to default-disable or so?
Done
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48920 )
Change subject: mb/clevo/n13xwu: Disable GMM PCI device ......................................................................
Patch Set 4: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48920 )
Change subject: mb/clevo/n13xwu: Disable GMM PCI device ......................................................................
mb/clevo/n13xwu: Disable GMM PCI device
We don't know exactly for what the GMM PCI device is used for or how it is used. Thus, remove it to fallback to default-disable.
Change-Id: I4b8b33b16527cbcc21168b995cbfdb54a2fa3cac Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/48920 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb b/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb index 6a4f97d..808ece0 100644 --- a/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb +++ b/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb @@ -46,7 +46,6 @@ device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device device pci 04.0 on end # SA thermal subsystem - device pci 08.0 on end # Gaussian Mixture Model device pci 14.0 on # USB xHCI register "SsicPortEnable" = "0" # USB2