Change in coreboot[master]: mb/google/octopus: Add EMRight digitizer support

[Chen Wisley (Code Review)]

Hello Wisley Chen,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/34652

to review the following change.

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

mb/google/octopus: Add EMRight digitizer support

The device Vortininja uses the variant meep, and suports WACOM/EMRIGHT
digitizer.

BUG=b:138276179
BRANCH=octopus
TEST=verified that WACOM/EMRIGHT digitizer can work.

Change-Id: I2bed4edb0261953f122f1d9ccca1fe4fa9406b33
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/octopus/variants/meep/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/34652/1

diff --git a/src/mainboard/google/octopus/variants/meep/overridetree.cb b/src/mainboard/google/octopus/variants/meep/overridetree.cb
index bff4c14..7264eaf 100644
--- a/src/mainboard/google/octopus/variants/meep/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/meep/overridetree.cb
@@ -147,9 +147,21 @@
    			register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
    			register "generic.reset_delay_ms" = "20"
    			register "generic.has_power_resource" = "1"
+				register "generic.probed" = "1"
    			register "hid_desc_reg_offset" = "0x1"
    			device i2c 0x9 on end
    		end
+                        chip drivers/i2c/hid
+                                register "generic.hid" = ""EMRTE635""
+                                register "generic.desc" = ""EMRIGHT Digitizer""
+                                register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_139_IRQ)"
+                                register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
+                                register "generic.reset_delay_ms" = "20"
+				register "generic.has_power_resource" = "1"
+				register "generic.probed" = "1"
+                                register "hid_desc_reg_offset" = "0x1"
+                                device i2c 0xa on end
+                        end
    	end	# - I2C 0
    	device pci 17.1 on
    		chip drivers/i2c/da7219

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/34652/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34652/1//COMMIT_MSG@9 
PS1, Line 9: suports
supports

https://review.coreboot.org/c/coreboot/+/34652/1//COMMIT_MSG@14 
PS1, Line 14: can work
works

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

Patch Set 1:

LGTM once Paul's comments are addressed.

[Chen Wisley (Code Review)]

Hello Karthikeyan Ramasubramanian, Marco Chen, Wisley Chen, Justin TerAvest, Paul Menzel, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34652

to look at the new patch set (#2).

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

mb/google/octopus: Add EMRight digitizer support

The device Vortininja uses the variant meep, and supports WACOM/EMRIGHT
digitizer.

BUG=b:138276179
BRANCH=octopus
TEST=verified that WACOM/EMRIGHT digitizer can works.

Change-Id: I2bed4edb0261953f122f1d9ccca1fe4fa9406b33
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/octopus/variants/meep/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/34652/2

[Chen Wisley (Code Review)]

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34652/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34652/1//COMMIT_MSG@9 
PS1, Line 9: suports
> supports

Done

https://review.coreboot.org/c/coreboot/+/34652/1//COMMIT_MSG@14 
PS1, Line 14: can work
> works

Done

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

Patch Set 2: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

Patch Set 2: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

Patch Set 2: Code-Review-1

(1 comment)

https://review.coreboot.org/c/coreboot/+/34652/2/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/meep/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/34652/2/src/mainboard/google/octopu... 
PS2, Line 154:                         
Could you make sure these are all tabs?  It looks like a mixture of tabs and spaces.

[Chen Wisley (Code Review)]

Hello Karthik Ramasubramanian, Karthikeyan Ramasubramanian, Marco Chen, Wisley Chen, Justin TerAvest, Paul Menzel, build bot (Jenkins), Martin Roth, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34652

to look at the new patch set (#3).

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

mb/google/octopus: Add EMRight digitizer support

The device Vortininja uses the variant meep, and supports WACOM/EMRIGHT
digitizer.

BUG=b:138276179
BRANCH=octopus
TEST=verified that WACOM/EMRIGHT digitizer can works.

Change-Id: I2bed4edb0261953f122f1d9ccca1fe4fa9406b33
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/octopus/variants/meep/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/34652/3

[Chen Wisley (Code Review)]

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34652/2/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/meep/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/34652/2/src/mainboard/google/octopu... 
PS2, Line 154:
> Could you make sure these are all tabs?  It looks like a mixture of tabs and spaces.

Done

[Chen Wisley (Code Review)]

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

Patch Set 3:

please help review again.
Thanks

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

Patch Set 3: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

Patch Set 3: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34652 )

Change subject: mb/google/octopus: Add EMRight digitizer support
......................................................................

mb/google/octopus: Add EMRight digitizer support

The device Vortininja uses the variant meep, and supports WACOM/EMRIGHT
digitizer.

BUG=b:138276179
BRANCH=octopus
TEST=verified that WACOM/EMRIGHT digitizer can works.

Change-Id: I2bed4edb0261953f122f1d9ccca1fe4fa9406b33
Signed-off-by: Wisley Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34652
Tested-by: build bot (Jenkins) 
Reviewed-by: Justin TerAvest 
Reviewed-by: Karthik Ramasubramanian 
---
M src/mainboard/google/octopus/variants/meep/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Justin TerAvest: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/octopus/variants/meep/overridetree.cb b/src/mainboard/google/octopus/variants/meep/overridetree.cb
index bff4c14..d7bdd2e 100644
--- a/src/mainboard/google/octopus/variants/meep/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/meep/overridetree.cb
@@ -147,9 +147,21 @@
    			register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
    			register "generic.reset_delay_ms" = "20"
    			register "generic.has_power_resource" = "1"
+				register "generic.probed" = "1"
    			register "hid_desc_reg_offset" = "0x1"
    			device i2c 0x9 on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""EMRTE635""
+				register "generic.desc" = ""EMRIGHT Digitizer""
+				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_139_IRQ)"
+				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)"
+				register "generic.reset_delay_ms" = "20"
+				register "generic.has_power_resource" = "1"
+				register "generic.probed" = "1"
+				register "hid_desc_reg_offset" = "0x1"
+				device i2c 0xa on end
+			end
    	end	# - I2C 0
    	device pci 17.1 on
    		chip drivers/i2c/da7219