Attention is currently required from: V Sowmya, Cliff Huang, Tim Wawrzynczak, Paul Menzel, Balaji Manigandan, Bernardo Perez Priego, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55127 )
Change subject: soc/intel/common/acpi: add ACPI S0ix _DSM for Intel Power Engine Plug-in
......................................................................
Patch Set 8:
(5 comments)
File src/soc/intel/common/block/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/55127/comment/59e5b485_6629563d
PS8, Line 34: Generate S0ix entries for Intel power engine plug-in. Linux exposes this under `/sys/kernel/debug/pmc_core/substate_requirement_registers`.
reflow, please
File src/soc/intel/common/block/acpi/acpi/pep.asl:
https://review.coreboot.org/c/coreboot/+/55127/comment/9b90d8d2_51a3aa89
PS8, Line 143: ((
nit: no need for double braces
https://review.coreboot.org/c/coreboot/+/55127/comment/760c144d_c761b514
PS8, Line 143: 57a6512e-3979-4e9d-9708-ff13b2508972
this UUID is only valid for >= TGL, isn't it? maybe add a comment to make this clear?
https://review.coreboot.org/c/coreboot/+/55127/comment/9c976e1a_8a458b8b
PS8, Line 145: ((Arg2 == Zero))
nit: no need for double braces
https://review.coreboot.org/c/coreboot/+/55127/comment/3f9209f7_a5369b72
PS8, Line 148: ((Arg2 == 0x01))
nit: no need for double braces
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I991662cbebf63bd71139ed37ff2588ba73f30398
Gerrit-Change-Number: 55127
Gerrit-PatchSet: 8
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Sukumar Ghorai
sukumar.ghorai@gmail.com
Gerrit-CC: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 04 Jun 2021 18:24:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment