Attention is currently required from: Felix Singer, Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59311 )
Change subject: soc/intel/../thermal: Fix return type of `pch_get_ltt_value()`
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59311/comment/da500cc7_5638273a
PS1, Line 7: Modified `pch_get_ltt_value()` return type
How about this: […]
I was more worried about no crossing >72 😊
Thanks for your suggestion
https://review.coreboot.org/c/coreboot/+/59311/comment/389fd7bb_c9eac54d
PS1, Line 9: This patch modifies the pch_get_ltt_value() function return type from
: uint16_t to uint32_t.
Please explain why. That bug number below isn't very helpful for outstanding people.
Sure, my bad.
Patchset:
PS1:
Just curious, why need change to int32? PCH register enlarge to DWORD?
Yes Eric, its due to https://review.coreboot.org/c/coreboot/+/59209/8/src/soc/intel/common/block/... where we have to program T2L, T1L and T0L level instead of only 1 threshold level.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59311
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f46ccb457b9cfebf13a512eabb3fb0fab8adb39
Gerrit-Change-Number: 59311
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 16 Nov 2021 13:23:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment