Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72418?usp=email )
Change subject: drivers/intel/gma: Dump output setting only if DEBUG_ADA_CODE is set
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Why was this changed? We don't hide the output of other components in coreboot
by default either. Without this, it's impossible to see if libgfxinit did any-
thing at all in the log of a release build. Is this really what we want?
Please disclose all the information from the Google bug tracker.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72418?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iadd6c9552b184f7d6ec8df9d0d392634864ba50c
Gerrit-Change-Number: 72418
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Comment-Date: Mon, 22 Apr 2024 15:39:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment