[M] Change in coreboot[main]: ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode

[Sean Rhodes (Code Review)]

Attention is currently required from: Paul Menzel.

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83879?usp=email )

Change subject: ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode
......................................................................

Patch Set 4:

(8 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83879/comment/4ea8c006_a6a8cb3b?usp... :
PS3, Line 15: Ubuntu
> Which version?

Done

https://review.coreboot.org/c/coreboot/+/83879/comment/facdcb7a_c463788a?usp... :
PS3, Line 16: show
> show*n*

Done

https://review.coreboot.org/c/coreboot/+/83879/comment/68f04483_6251a816?usp... :
PS3, Line 15: Tested on `starlite_adl` with Ubuntu, by checking the
            : virtual keyboard is show when the tablet is undocked
            : and hidden when docked.
> Can it be tested by looking at some logs?

Done

https://review.coreboot.org/c/coreboot/+/83879/comment/4c83b997_f9557ea6?usp... :
PS3, Line 9: Add Intel Virtual Button driver which is used to report
           : to the OS whether a tablet is docked or undocked.
           : 
           : This is currently only used on `mb/starlite_adl` so the
           : GPIO is hardcoded to GPP_F15 for now.
           : 
           : Tested on `starlite_adl` with Ubuntu, by checking the
           : virtual keyboard is show when the tablet is undocked
           : and hidden when docked.
> Please try to use 72 characters per line.

Done

File src/ec/starlabs/merlin/acpi/battery.asl:

PS3:
> This is from a different commit, isn’t it?

Done

File src/ec/starlabs/merlin/acpi/dock.asl:

PS3:
> There is already: […]

Not any way that I can see that wouldn't overconplicate it.

File src/ec/starlabs/merlin/acpi/ec.asl:

https://review.coreboot.org/c/coreboot/+/83879/comment/fe308e5a_9aabd4fb?usp... :
PS3, Line 53: #if CONFIG(SOC_INTEL_COMMON)
            : 			\LIDS = 0x03
            : #endif
> Please comment in the commit message why this is done, or add a comment?

Done

File src/ec/starlabs/merlin/acpi/hid.asl:

https://review.coreboot.org/c/coreboot/+/83879/comment/f023f8e0_32f02d9b?usp... :
PS3, Line 352: Case (0x08)
             : 					{
             : 						Return (_SB.PCI0.LPCB.EC.VBTN.VGBS())
             : 					}
> Please mention this in the commit message?

Done