Attention is currently required from: Nico Huber, Michael Niewöhner, Karthik Ramasubramanian.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49426 )
Change subject: mb/google/octopus: do UART pad configuration at board-level
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/49426/comment/0b84cb0a_39b58af6
PS4, Line 297: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_64, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART2_RXD */
line over 96 characters
https://review.coreboot.org/c/coreboot/+/49426/comment/141f455c_b812bf6d
PS4, Line 298: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_65, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART2_TXD */
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieeb738afd54e77ee853ee109009f611411aa0d4a
Gerrit-Change-Number: 49426
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 20 Jan 2021 19:07:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment