HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33530
Change subject: src/soc: Remove unused include <device/pci_ops.h> ......................................................................
src/soc: Remove unused include <device/pci_ops.h>
Change-Id: I80c92f744fb9a6c3788b8b9ba779deef76e58943 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/common/block/hda/hda.c M src/soc/amd/common/block/iommu/iommu.c M src/soc/amd/common/block/pi/amd_late_init.c M src/soc/amd/common/block/sata/sata.c M src/soc/amd/stoneyridge/sm.c M src/soc/amd/stoneyridge/spi.c M src/soc/intel/baytrail/bootblock/bootblock.c M src/soc/intel/baytrail/chip.c M src/soc/intel/baytrail/elog.c M src/soc/intel/baytrail/iosf.c M src/soc/intel/braswell/elog.c M src/soc/intel/braswell/iosf.c M src/soc/intel/broadwell/bootblock/systemagent.c M src/soc/intel/broadwell/chip.c M src/soc/intel/cannonlake/pmc.c M src/soc/intel/common/block/hda/hda.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/denverton_ns/chip.c M src/soc/intel/denverton_ns/uart_debug.c M src/soc/intel/fsp_baytrail/chip.c M src/soc/intel/fsp_baytrail/iosf.c M src/soc/intel/fsp_broadwell_de/chip.c M src/soc/intel/icelake/pmc.c M src/soc/intel/quark/include/soc/ramstage.h 24 files changed, 0 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/33530/1
diff --git a/src/soc/amd/common/block/hda/hda.c b/src/soc/amd/common/block/hda/hda.c index f4ea732..2f81780 100644 --- a/src/soc/amd/common/block/hda/hda.c +++ b/src/soc/amd/common/block/hda/hda.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h>
static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_SB900_HDA, diff --git a/src/soc/amd/common/block/iommu/iommu.c b/src/soc/amd/common/block/iommu/iommu.c index 1c982ca..ac7beed 100644 --- a/src/soc/amd/common/block/iommu/iommu.c +++ b/src/soc/amd/common/block/iommu/iommu.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <lib.h>
static void iommu_read_resources(struct device *dev) diff --git a/src/soc/amd/common/block/pi/amd_late_init.c b/src/soc/amd/common/block/pi/amd_late_init.c index 80c7add..f2b4ed1 100644 --- a/src/soc/amd/common/block/pi/amd_late_init.c +++ b/src/soc/amd/common/block/pi/amd_late_init.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci_def.h> -#include <device/pci_ops.h> #include <dimm_info_util.h> #include <memory_info.h> #include <lib.h> diff --git a/src/soc/amd/common/block/sata/sata.c b/src/soc/amd/common/block/sata/sata.c index cbbc7cf..5aa2088 100644 --- a/src/soc/amd/common/block/sata/sata.c +++ b/src/soc/amd/common/block/sata/sata.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <amdblocks/sata.h>
void __weak soc_enable_sata_features(struct device *dev) { } diff --git a/src/soc/amd/stoneyridge/sm.c b/src/soc/amd/stoneyridge/sm.c index 803e628..fbcddfa 100644 --- a/src/soc/amd/stoneyridge/sm.c +++ b/src/soc/amd/stoneyridge/sm.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/smbus.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> diff --git a/src/soc/amd/stoneyridge/spi.c b/src/soc/amd/stoneyridge/spi.c index 8abfa16..60b6a20 100644 --- a/src/soc/amd/stoneyridge/spi.c +++ b/src/soc/amd/stoneyridge/spi.c @@ -24,7 +24,6 @@ #include <spi-generic.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <soc/southbridge.h> #include <amdblocks/lpc.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/baytrail/bootblock/bootblock.c b/src/soc/intel/baytrail/bootblock/bootblock.c index b2cdf9d..9a189e3 100644 --- a/src/soc/intel/baytrail/bootblock/bootblock.c +++ b/src/soc/intel/baytrail/bootblock/bootblock.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <device/pci_ops.h> #include <cpu/x86/cache.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/baytrail/chip.c b/src/soc/intel/baytrail/chip.c index acac679..6f0d98a 100644 --- a/src/soc/intel/baytrail/chip.c +++ b/src/soc/intel/baytrail/chip.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <arch/pci_ops.h>
#include <soc/pci_devs.h> diff --git a/src/soc/intel/baytrail/elog.c b/src/soc/intel/baytrail/elog.c index 45dcec8..d7a0460 100644 --- a/src/soc/intel/baytrail/elog.c +++ b/src/soc/intel/baytrail/elog.c @@ -20,7 +20,6 @@ #include <cbmem.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <elog.h> #include <soc/iomap.h> #include <soc/pmc.h> diff --git a/src/soc/intel/baytrail/iosf.c b/src/soc/intel/baytrail/iosf.c index bb5e80c..9974a22 100644 --- a/src/soc/intel/baytrail/iosf.c +++ b/src/soc/intel/baytrail/iosf.c @@ -14,7 +14,6 @@ */
#include <stdint.h> -#include <device/pci_ops.h> #include <soc/iosf.h>
static inline void write_iosf_reg(int reg, uint32_t value) diff --git a/src/soc/intel/braswell/elog.c b/src/soc/intel/braswell/elog.c index f1fc7d4..6efcef1 100644 --- a/src/soc/intel/braswell/elog.c +++ b/src/soc/intel/braswell/elog.c @@ -20,7 +20,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <elog.h> #include <soc/iomap.h> #include <soc/pm.h> diff --git a/src/soc/intel/braswell/iosf.c b/src/soc/intel/braswell/iosf.c index 5aa6181..71bf3a6 100644 --- a/src/soc/intel/braswell/iosf.c +++ b/src/soc/intel/braswell/iosf.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <device/pci_ops.h> #include <console/console.h> #include <soc/iosf.h>
diff --git a/src/soc/intel/broadwell/bootblock/systemagent.c b/src/soc/intel/broadwell/bootblock/systemagent.c index 7aaed78..62a5330 100644 --- a/src/soc/intel/broadwell/bootblock/systemagent.c +++ b/src/soc/intel/broadwell/bootblock/systemagent.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <device/pci_ops.h> #include <soc/pci_devs.h> #include <soc/systemagent.h> #include <cpu/intel/car/bootblock.h> diff --git a/src/soc/intel/broadwell/chip.c b/src/soc/intel/broadwell/chip.c index caff026..2b9f6a1 100644 --- a/src/soc/intel/broadwell/chip.c +++ b/src/soc/intel/broadwell/chip.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <soc/acpi.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> diff --git a/src/soc/intel/cannonlake/pmc.c b/src/soc/intel/cannonlake/pmc.c index 6834aa2..19478c2 100644 --- a/src/soc/intel/cannonlake/pmc.c +++ b/src/soc/intel/cannonlake/pmc.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/mmio.h> #include <device/device.h> -#include <device/pci_ops.h> #include <intelblocks/pmc.h> #include <intelblocks/pmclib.h> #include <intelblocks/rtc.h> diff --git a/src/soc/intel/common/block/hda/hda.c b/src/soc/intel/common/block/hda/hda.c index 8ab835e..f4b8789 100644 --- a/src/soc/intel/common/block/hda/hda.c +++ b/src/soc/intel/common/block/hda/hda.c @@ -19,7 +19,6 @@ #include <device/azalia_device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/intel/common/hda_verb.h> #include <soc/ramstage.h>
diff --git a/src/soc/intel/common/block/smbus/smbus.c b/src/soc/intel/common/block/smbus/smbus.c index fc22577..2a0ab4b 100644 --- a/src/soc/intel/common/block/smbus/smbus.c +++ b/src/soc/intel/common/block/smbus/smbus.c @@ -19,7 +19,6 @@ #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/smbus.h> #include "smbuslib.h"
diff --git a/src/soc/intel/denverton_ns/chip.c b/src/soc/intel/denverton_ns/chip.c index b72bf28..c21a2a7 100644 --- a/src/soc/intel/denverton_ns/chip.c +++ b/src/soc/intel/denverton_ns/chip.c @@ -21,7 +21,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <fsp/api.h> #include <fsp/util.h> #include <intelblocks/fast_spi.h> diff --git a/src/soc/intel/denverton_ns/uart_debug.c b/src/soc/intel/denverton_ns/uart_debug.c index f7d523e..8fb1fab 100644 --- a/src/soc/intel/denverton_ns/uart_debug.c +++ b/src/soc/intel/denverton_ns/uart_debug.c @@ -16,7 +16,6 @@
#include <stdint.h> #include <device/pci_def.h> -#include <device/pci_ops.h> #include <soc/uart.h>
#define MY_PCI_DEV(SEGBUS, DEV, FN) \ diff --git a/src/soc/intel/fsp_baytrail/chip.c b/src/soc/intel/fsp_baytrail/chip.c index 9e86279..3ca26ad 100644 --- a/src/soc/intel/fsp_baytrail/chip.c +++ b/src/soc/intel/fsp_baytrail/chip.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <drivers/intel/fsp1_0/fsp_util.h> diff --git a/src/soc/intel/fsp_baytrail/iosf.c b/src/soc/intel/fsp_baytrail/iosf.c index 25f82ab..ea5d9d5 100644 --- a/src/soc/intel/fsp_baytrail/iosf.c +++ b/src/soc/intel/fsp_baytrail/iosf.c @@ -16,7 +16,6 @@ */
#include <stdint.h> -#include <device/pci_ops.h> #include <soc/iosf.h>
static inline void write_iosf_reg(int reg, uint32_t value) diff --git a/src/soc/intel/fsp_broadwell_de/chip.c b/src/soc/intel/fsp_broadwell_de/chip.c index a0b3f7c..a1978fa4 100644 --- a/src/soc/intel/fsp_broadwell_de/chip.c +++ b/src/soc/intel/fsp_broadwell_de/chip.c @@ -18,7 +18,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <drivers/intel/fsp1_0/fsp_util.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> diff --git a/src/soc/intel/icelake/pmc.c b/src/soc/intel/icelake/pmc.c index 8f61d70..ad71359 100644 --- a/src/soc/intel/icelake/pmc.c +++ b/src/soc/intel/icelake/pmc.c @@ -17,7 +17,6 @@ #include <console/console.h> #include <device/mmio.h> #include <device/device.h> -#include <device/pci_ops.h> #include <intelblocks/pmc.h> #include <intelblocks/pmclib.h> #include <intelblocks/rtc.h> diff --git a/src/soc/intel/quark/include/soc/ramstage.h b/src/soc/intel/quark/include/soc/ramstage.h index 56be795..ada8899 100644 --- a/src/soc/intel/quark/include/soc/ramstage.h +++ b/src/soc/intel/quark/include/soc/ramstage.h @@ -19,7 +19,6 @@
#include <arch/cpu.h> #include <device/device.h> -#include <device/pci_ops.h> #include <soc/QuarkNcSocId.h>
#include "../../chip.h"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33530
to look at the new patch set (#2).
Change subject: src/soc: Remove unused include <device/pci_ops.h> ......................................................................
src/soc: Remove unused include <device/pci_ops.h>
Change-Id: I80c92f744fb9a6c3788b8b9ba779deef76e58943 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/common/block/hda/hda.c M src/soc/amd/common/block/iommu/iommu.c M src/soc/amd/common/block/pi/amd_late_init.c M src/soc/amd/common/block/sata/sata.c M src/soc/amd/stoneyridge/sm.c M src/soc/amd/stoneyridge/spi.c M src/soc/intel/baytrail/chip.c M src/soc/intel/baytrail/elog.c M src/soc/intel/baytrail/iosf.c M src/soc/intel/braswell/elog.c M src/soc/intel/braswell/iosf.c M src/soc/intel/broadwell/chip.c M src/soc/intel/cannonlake/pmc.c M src/soc/intel/common/block/hda/hda.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/denverton_ns/chip.c M src/soc/intel/fsp_baytrail/chip.c M src/soc/intel/fsp_baytrail/iosf.c M src/soc/intel/fsp_broadwell_de/chip.c M src/soc/intel/icelake/pmc.c M src/soc/intel/quark/include/soc/ramstage.h 21 files changed, 0 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/33530/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33530
to look at the new patch set (#3).
Change subject: src/soc: Remove unused include <device/pci_ops.h> ......................................................................
src/soc: Remove unused include <device/pci_ops.h>
Change-Id: I80c92f744fb9a6c3788b8b9ba779deef76e58943 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/common/block/hda/hda.c M src/soc/amd/common/block/iommu/iommu.c M src/soc/amd/common/block/pi/amd_late_init.c M src/soc/amd/common/block/sata/sata.c M src/soc/amd/stoneyridge/sm.c M src/soc/amd/stoneyridge/spi.c M src/soc/intel/baytrail/chip.c M src/soc/intel/baytrail/elog.c M src/soc/intel/braswell/elog.c M src/soc/intel/broadwell/chip.c M src/soc/intel/cannonlake/pmc.c M src/soc/intel/common/block/hda/hda.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/denverton_ns/chip.c M src/soc/intel/fsp_baytrail/chip.c M src/soc/intel/fsp_broadwell_de/chip.c M src/soc/intel/icelake/pmc.c M src/soc/intel/quark/include/soc/ramstage.h 18 files changed, 0 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/33530/3
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33530 )
Change subject: src/soc: Remove unused include <device/pci_ops.h> ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33530 )
Change subject: src/soc: Remove unused include <device/pci_ops.h> ......................................................................
src/soc: Remove unused include <device/pci_ops.h>
Change-Id: I80c92f744fb9a6c3788b8b9ba779deef76e58943 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33530 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/hda/hda.c M src/soc/amd/common/block/iommu/iommu.c M src/soc/amd/common/block/pi/amd_late_init.c M src/soc/amd/common/block/sata/sata.c M src/soc/amd/stoneyridge/sm.c M src/soc/amd/stoneyridge/spi.c M src/soc/intel/baytrail/chip.c M src/soc/intel/baytrail/elog.c M src/soc/intel/braswell/elog.c M src/soc/intel/broadwell/chip.c M src/soc/intel/cannonlake/pmc.c M src/soc/intel/common/block/hda/hda.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/denverton_ns/chip.c M src/soc/intel/fsp_baytrail/chip.c M src/soc/intel/fsp_broadwell_de/chip.c M src/soc/intel/icelake/pmc.c M src/soc/intel/quark/include/soc/ramstage.h 18 files changed, 0 insertions(+), 18 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/soc/amd/common/block/hda/hda.c b/src/soc/amd/common/block/hda/hda.c index df3dc5e..27510c3 100644 --- a/src/soc/amd/common/block/hda/hda.c +++ b/src/soc/amd/common/block/hda/hda.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h>
static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_SB900_HDA, diff --git a/src/soc/amd/common/block/iommu/iommu.c b/src/soc/amd/common/block/iommu/iommu.c index c068501..18c8e66 100644 --- a/src/soc/amd/common/block/iommu/iommu.c +++ b/src/soc/amd/common/block/iommu/iommu.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <lib.h>
static void iommu_read_resources(struct device *dev) diff --git a/src/soc/amd/common/block/pi/amd_late_init.c b/src/soc/amd/common/block/pi/amd_late_init.c index 80c7add..f2b4ed1 100644 --- a/src/soc/amd/common/block/pi/amd_late_init.c +++ b/src/soc/amd/common/block/pi/amd_late_init.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci_def.h> -#include <device/pci_ops.h> #include <dimm_info_util.h> #include <memory_info.h> #include <lib.h> diff --git a/src/soc/amd/common/block/sata/sata.c b/src/soc/amd/common/block/sata/sata.c index cbbc7cf..5aa2088 100644 --- a/src/soc/amd/common/block/sata/sata.c +++ b/src/soc/amd/common/block/sata/sata.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <amdblocks/sata.h>
void __weak soc_enable_sata_features(struct device *dev) { } diff --git a/src/soc/amd/stoneyridge/sm.c b/src/soc/amd/stoneyridge/sm.c index 803e628..fbcddfa 100644 --- a/src/soc/amd/stoneyridge/sm.c +++ b/src/soc/amd/stoneyridge/sm.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <device/smbus.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> diff --git a/src/soc/amd/stoneyridge/spi.c b/src/soc/amd/stoneyridge/spi.c index 8abfa16..60b6a20 100644 --- a/src/soc/amd/stoneyridge/spi.c +++ b/src/soc/amd/stoneyridge/spi.c @@ -24,7 +24,6 @@ #include <spi-generic.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <soc/southbridge.h> #include <amdblocks/lpc.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/baytrail/chip.c b/src/soc/intel/baytrail/chip.c index acac679..6f0d98a 100644 --- a/src/soc/intel/baytrail/chip.c +++ b/src/soc/intel/baytrail/chip.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <arch/pci_ops.h>
#include <soc/pci_devs.h> diff --git a/src/soc/intel/baytrail/elog.c b/src/soc/intel/baytrail/elog.c index 45dcec8..d7a0460 100644 --- a/src/soc/intel/baytrail/elog.c +++ b/src/soc/intel/baytrail/elog.c @@ -20,7 +20,6 @@ #include <cbmem.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <elog.h> #include <soc/iomap.h> #include <soc/pmc.h> diff --git a/src/soc/intel/braswell/elog.c b/src/soc/intel/braswell/elog.c index f1fc7d4..6efcef1 100644 --- a/src/soc/intel/braswell/elog.c +++ b/src/soc/intel/braswell/elog.c @@ -20,7 +20,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <elog.h> #include <soc/iomap.h> #include <soc/pm.h> diff --git a/src/soc/intel/broadwell/chip.c b/src/soc/intel/broadwell/chip.c index caff026..2b9f6a1 100644 --- a/src/soc/intel/broadwell/chip.c +++ b/src/soc/intel/broadwell/chip.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <soc/acpi.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> diff --git a/src/soc/intel/cannonlake/pmc.c b/src/soc/intel/cannonlake/pmc.c index 0e7cc17..b9f455f 100644 --- a/src/soc/intel/cannonlake/pmc.c +++ b/src/soc/intel/cannonlake/pmc.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/mmio.h> #include <device/device.h> -#include <device/pci_ops.h> #include <intelblocks/pmc.h> #include <intelblocks/pmclib.h> #include <intelblocks/rtc.h> diff --git a/src/soc/intel/common/block/hda/hda.c b/src/soc/intel/common/block/hda/hda.c index 96d26d4..0cf9baa 100644 --- a/src/soc/intel/common/block/hda/hda.c +++ b/src/soc/intel/common/block/hda/hda.c @@ -19,7 +19,6 @@ #include <device/azalia_device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/intel/common/hda_verb.h> #include <soc/ramstage.h>
diff --git a/src/soc/intel/common/block/smbus/smbus.c b/src/soc/intel/common/block/smbus/smbus.c index 700d2b7..77b05c1 100644 --- a/src/soc/intel/common/block/smbus/smbus.c +++ b/src/soc/intel/common/block/smbus/smbus.c @@ -19,7 +19,6 @@ #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <soc/smbus.h> #include "smbuslib.h"
diff --git a/src/soc/intel/denverton_ns/chip.c b/src/soc/intel/denverton_ns/chip.c index b72bf28..c21a2a7 100644 --- a/src/soc/intel/denverton_ns/chip.c +++ b/src/soc/intel/denverton_ns/chip.c @@ -21,7 +21,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <fsp/api.h> #include <fsp/util.h> #include <intelblocks/fast_spi.h> diff --git a/src/soc/intel/fsp_baytrail/chip.c b/src/soc/intel/fsp_baytrail/chip.c index 9e86279..3ca26ad 100644 --- a/src/soc/intel/fsp_baytrail/chip.c +++ b/src/soc/intel/fsp_baytrail/chip.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <drivers/intel/fsp1_0/fsp_util.h> diff --git a/src/soc/intel/fsp_broadwell_de/chip.c b/src/soc/intel/fsp_broadwell_de/chip.c index a0b3f7c..a1978fa4 100644 --- a/src/soc/intel/fsp_broadwell_de/chip.c +++ b/src/soc/intel/fsp_broadwell_de/chip.c @@ -18,7 +18,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <drivers/intel/fsp1_0/fsp_util.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> diff --git a/src/soc/intel/icelake/pmc.c b/src/soc/intel/icelake/pmc.c index 1889c4b..28fc01d 100644 --- a/src/soc/intel/icelake/pmc.c +++ b/src/soc/intel/icelake/pmc.c @@ -17,7 +17,6 @@ #include <console/console.h> #include <device/mmio.h> #include <device/device.h> -#include <device/pci_ops.h> #include <intelblocks/pmc.h> #include <intelblocks/pmclib.h> #include <intelblocks/rtc.h> diff --git a/src/soc/intel/quark/include/soc/ramstage.h b/src/soc/intel/quark/include/soc/ramstage.h index 56be795..ada8899 100644 --- a/src/soc/intel/quark/include/soc/ramstage.h +++ b/src/soc/intel/quark/include/soc/ramstage.h @@ -19,7 +19,6 @@
#include <arch/cpu.h> #include <device/device.h> -#include <device/pci_ops.h> #include <soc/QuarkNcSocId.h>
#include "../../chip.h"
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)