Attention is currently required from: Mario Scheithauer, Werner Zeh.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74628 )
Change subject: mb/siemens/mc_ehl4: Adjust GPIOs
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74628/comment/010a98ae_b359a40a
PS2, Line 9: Set the GPIOs according to the circuit diagram for this mainboard.
For me it’s unclear, if the GPIO configuration was copy-pasted before, and therefore was wrong or not. It’d be great, if you made that clear.
File src/mainboard/siemens/mc_ehl/variants/mc_ehl4/gpio.c:
https://review.coreboot.org/c/coreboot/+/74628/comment/9ac3fd4e_9600d4ed
PS2, Line 8:
Unrelated?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66bfbb380e9a05b3a2c08d5d1980e9749b46ee43
Gerrit-Change-Number: 74628
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 12:00:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment