HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43565 )
Change subject: sc: Remove unneeded whitespace ......................................................................
sc: Remove unneeded whitespace
Change-Id: Iac0f0c3d102a9a900ac168f8be907349d9a3dd42 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/51nb/npce985la0dx/npce985la0dx.c M src/mainboard/51nb/x210/acpi/battery.asl M src/mainboard/51nb/x210/acpi/ec.asl M src/mainboard/51nb/x210/acpi/graphics.asl M src/mainboard/51nb/x210/acpi/mainboard.asl M src/mainboard/51nb/x210/acpi/platform.asl M src/mainboard/51nb/x210/acpi/superio.asl M src/mainboard/51nb/x210/dsdt.asl M src/mainboard/51nb/x210/gpio.h M src/mainboard/51nb/x210/hda_verb.c M src/mainboard/51nb/x210/mainboard.c M src/mainboard/51nb/x210/romstage.c M src/mainboard/google/dedede/romstage.c 13 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/43565/1
diff --git a/src/ec/51nb/npce985la0dx/npce985la0dx.c b/src/ec/51nb/npce985la0dx/npce985la0dx.c index f435d32..06db530 100644 --- a/src/ec/51nb/npce985la0dx/npce985la0dx.c +++ b/src/ec/51nb/npce985la0dx/npce985la0dx.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <device/pnp.h>
diff --git a/src/mainboard/51nb/x210/acpi/battery.asl b/src/mainboard/51nb/x210/acpi/battery.asl index 33e5aeb..f9022a4 100644 --- a/src/mainboard/51nb/x210/acpi/battery.asl +++ b/src/mainboard/51nb/x210/acpi/battery.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
Device (BAT) { diff --git a/src/mainboard/51nb/x210/acpi/ec.asl b/src/mainboard/51nb/x210/acpi/ec.asl index c7a9177..78e156c 100644 --- a/src/mainboard/51nb/x210/acpi/ec.asl +++ b/src/mainboard/51nb/x210/acpi/ec.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
Device (EC) { diff --git a/src/mainboard/51nb/x210/acpi/graphics.asl b/src/mainboard/51nb/x210/acpi/graphics.asl index 3c44c47..e703ba1 100644 --- a/src/mainboard/51nb/x210/acpi/graphics.asl +++ b/src/mainboard/51nb/x210/acpi/graphics.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
Device (GFX0) { diff --git a/src/mainboard/51nb/x210/acpi/mainboard.asl b/src/mainboard/51nb/x210/acpi/mainboard.asl index c8c4f25..89df7f4 100644 --- a/src/mainboard/51nb/x210/acpi/mainboard.asl +++ b/src/mainboard/51nb/x210/acpi/mainboard.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
Scope (_SB) { diff --git a/src/mainboard/51nb/x210/acpi/platform.asl b/src/mainboard/51nb/x210/acpi/platform.asl index fc03335..6cf3f32 100644 --- a/src/mainboard/51nb/x210/acpi/platform.asl +++ b/src/mainboard/51nb/x210/acpi/platform.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
/* Enable ACPI _SWS methods */ #include <soc/intel/common/acpi/acpi_wake_source.asl> diff --git a/src/mainboard/51nb/x210/acpi/superio.asl b/src/mainboard/51nb/x210/acpi/superio.asl index 6fe3084..ee2eabe 100644 --- a/src/mainboard/51nb/x210/acpi/superio.asl +++ b/src/mainboard/51nb/x210/acpi/superio.asl @@ -1,3 +1,3 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <drivers/pc80/pc/ps2_controller.asl> diff --git a/src/mainboard/51nb/x210/dsdt.asl b/src/mainboard/51nb/x210/dsdt.asl index c648d42..dde48ab 100644 --- a/src/mainboard/51nb/x210/dsdt.asl +++ b/src/mainboard/51nb/x210/dsdt.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <acpi/acpi.h>
diff --git a/src/mainboard/51nb/x210/gpio.h b/src/mainboard/51nb/x210/gpio.h index c517b44..201fed6 100644 --- a/src/mainboard/51nb/x210/gpio.h +++ b/src/mainboard/51nb/x210/gpio.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#ifndef MAINBOARD_GPIO_H #define MAINBOARD_GPIO_H diff --git a/src/mainboard/51nb/x210/hda_verb.c b/src/mainboard/51nb/x210/hda_verb.c index 6799c38..730cc44 100644 --- a/src/mainboard/51nb/x210/hda_verb.c +++ b/src/mainboard/51nb/x210/hda_verb.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <device/azalia_device.h>
diff --git a/src/mainboard/51nb/x210/mainboard.c b/src/mainboard/51nb/x210/mainboard.c index 4e6f1d5..e05331c 100644 --- a/src/mainboard/51nb/x210/mainboard.c +++ b/src/mainboard/51nb/x210/mainboard.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <soc/ramstage.h> #include "gpio.h" diff --git a/src/mainboard/51nb/x210/romstage.c b/src/mainboard/51nb/x210/romstage.c index 60f008c..2112e25 100644 --- a/src/mainboard/51nb/x210/romstage.c +++ b/src/mainboard/51nb/x210/romstage.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <assert.h> #include <soc/romstage.h> diff --git a/src/mainboard/google/dedede/romstage.c b/src/mainboard/google/dedede/romstage.c index af79c80..db6f7db 100644 --- a/src/mainboard/google/dedede/romstage.c +++ b/src/mainboard/google/dedede/romstage.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/variants.h> #include <console/console.h>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43565
to look at the new patch set (#2).
Change subject: src: Remove unneeded whitespace ......................................................................
src: Remove unneeded whitespace
Change-Id: Iac0f0c3d102a9a900ac168f8be907349d9a3dd42 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/51nb/npce985la0dx/npce985la0dx.c M src/mainboard/51nb/x210/acpi/battery.asl M src/mainboard/51nb/x210/acpi/ec.asl M src/mainboard/51nb/x210/acpi/graphics.asl M src/mainboard/51nb/x210/acpi/mainboard.asl M src/mainboard/51nb/x210/acpi/platform.asl M src/mainboard/51nb/x210/acpi/superio.asl M src/mainboard/51nb/x210/dsdt.asl M src/mainboard/51nb/x210/gpio.h M src/mainboard/51nb/x210/hda_verb.c M src/mainboard/51nb/x210/mainboard.c M src/mainboard/51nb/x210/romstage.c M src/mainboard/google/dedede/romstage.c 13 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/43565/2
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43565 )
Change subject: src: Remove unneeded whitespace ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43565 )
Change subject: src: Remove unneeded whitespace ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43565 )
Change subject: src: Remove unneeded whitespace ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43565/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43565/2//COMMIT_MSG@7 PS2, Line 7: src: Remove unneeded whitespace
src: Remove unneeded space in license header
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43565 )
Change subject: src: Remove unneeded whitespace ......................................................................
Patch Set 2:
(1 comment)
Thx
https://review.coreboot.org/c/coreboot/+/43565/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43565/2//COMMIT_MSG@7 PS2, Line 7: src: Remove unneeded whitespace
src: Remove unneeded space in license header
Done
Hello build bot (Jenkins), Maxim Polyakov, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43565
to look at the new patch set (#3).
Change subject: src: Remove unneeded space in license header ......................................................................
src: Remove unneeded space in license header
Change-Id: Iac0f0c3d102a9a900ac168f8be907349d9a3dd42 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/51nb/npce985la0dx/npce985la0dx.c M src/mainboard/51nb/x210/acpi/battery.asl M src/mainboard/51nb/x210/acpi/ec.asl M src/mainboard/51nb/x210/acpi/graphics.asl M src/mainboard/51nb/x210/acpi/mainboard.asl M src/mainboard/51nb/x210/acpi/platform.asl M src/mainboard/51nb/x210/acpi/superio.asl M src/mainboard/51nb/x210/dsdt.asl M src/mainboard/51nb/x210/gpio.h M src/mainboard/51nb/x210/hda_verb.c M src/mainboard/51nb/x210/mainboard.c M src/mainboard/51nb/x210/romstage.c M src/mainboard/google/dedede/romstage.c 13 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/43565/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43565 )
Change subject: src: Remove unneeded space in license header ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43565 )
Change subject: src: Remove unneeded space in license header ......................................................................
src: Remove unneeded space in license header
Change-Id: Iac0f0c3d102a9a900ac168f8be907349d9a3dd42 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43565 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/51nb/npce985la0dx/npce985la0dx.c M src/mainboard/51nb/x210/acpi/battery.asl M src/mainboard/51nb/x210/acpi/ec.asl M src/mainboard/51nb/x210/acpi/graphics.asl M src/mainboard/51nb/x210/acpi/mainboard.asl M src/mainboard/51nb/x210/acpi/platform.asl M src/mainboard/51nb/x210/acpi/superio.asl M src/mainboard/51nb/x210/dsdt.asl M src/mainboard/51nb/x210/gpio.h M src/mainboard/51nb/x210/hda_verb.c M src/mainboard/51nb/x210/mainboard.c M src/mainboard/51nb/x210/romstage.c M src/mainboard/google/dedede/romstage.c 13 files changed, 13 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Maxim Polyakov: Looks good to me, approved
diff --git a/src/ec/51nb/npce985la0dx/npce985la0dx.c b/src/ec/51nb/npce985la0dx/npce985la0dx.c index f435d32..06db530 100644 --- a/src/ec/51nb/npce985la0dx/npce985la0dx.c +++ b/src/ec/51nb/npce985la0dx/npce985la0dx.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <device/pnp.h>
diff --git a/src/mainboard/51nb/x210/acpi/battery.asl b/src/mainboard/51nb/x210/acpi/battery.asl index 33e5aeb..f9022a4 100644 --- a/src/mainboard/51nb/x210/acpi/battery.asl +++ b/src/mainboard/51nb/x210/acpi/battery.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
Device (BAT) { diff --git a/src/mainboard/51nb/x210/acpi/ec.asl b/src/mainboard/51nb/x210/acpi/ec.asl index c7a9177..78e156c 100644 --- a/src/mainboard/51nb/x210/acpi/ec.asl +++ b/src/mainboard/51nb/x210/acpi/ec.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
Device (EC) { diff --git a/src/mainboard/51nb/x210/acpi/graphics.asl b/src/mainboard/51nb/x210/acpi/graphics.asl index 3c44c47..e703ba1 100644 --- a/src/mainboard/51nb/x210/acpi/graphics.asl +++ b/src/mainboard/51nb/x210/acpi/graphics.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
Device (GFX0) { diff --git a/src/mainboard/51nb/x210/acpi/mainboard.asl b/src/mainboard/51nb/x210/acpi/mainboard.asl index c8c4f25..89df7f4 100644 --- a/src/mainboard/51nb/x210/acpi/mainboard.asl +++ b/src/mainboard/51nb/x210/acpi/mainboard.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
Scope (_SB) { diff --git a/src/mainboard/51nb/x210/acpi/platform.asl b/src/mainboard/51nb/x210/acpi/platform.asl index fc03335..6cf3f32 100644 --- a/src/mainboard/51nb/x210/acpi/platform.asl +++ b/src/mainboard/51nb/x210/acpi/platform.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
/* Enable ACPI _SWS methods */ #include <soc/intel/common/acpi/acpi_wake_source.asl> diff --git a/src/mainboard/51nb/x210/acpi/superio.asl b/src/mainboard/51nb/x210/acpi/superio.asl index 6fe3084..ee2eabe 100644 --- a/src/mainboard/51nb/x210/acpi/superio.asl +++ b/src/mainboard/51nb/x210/acpi/superio.asl @@ -1,3 +1,3 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <drivers/pc80/pc/ps2_controller.asl> diff --git a/src/mainboard/51nb/x210/dsdt.asl b/src/mainboard/51nb/x210/dsdt.asl index c648d42..dde48ab 100644 --- a/src/mainboard/51nb/x210/dsdt.asl +++ b/src/mainboard/51nb/x210/dsdt.asl @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <acpi/acpi.h>
diff --git a/src/mainboard/51nb/x210/gpio.h b/src/mainboard/51nb/x210/gpio.h index c517b44..201fed6 100644 --- a/src/mainboard/51nb/x210/gpio.h +++ b/src/mainboard/51nb/x210/gpio.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#ifndef MAINBOARD_GPIO_H #define MAINBOARD_GPIO_H diff --git a/src/mainboard/51nb/x210/hda_verb.c b/src/mainboard/51nb/x210/hda_verb.c index 6799c38..730cc44 100644 --- a/src/mainboard/51nb/x210/hda_verb.c +++ b/src/mainboard/51nb/x210/hda_verb.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <device/azalia_device.h>
diff --git a/src/mainboard/51nb/x210/mainboard.c b/src/mainboard/51nb/x210/mainboard.c index 4e6f1d5..e05331c 100644 --- a/src/mainboard/51nb/x210/mainboard.c +++ b/src/mainboard/51nb/x210/mainboard.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <soc/ramstage.h> #include "gpio.h" diff --git a/src/mainboard/51nb/x210/romstage.c b/src/mainboard/51nb/x210/romstage.c index 60f008c..2112e25 100644 --- a/src/mainboard/51nb/x210/romstage.c +++ b/src/mainboard/51nb/x210/romstage.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <assert.h> #include <soc/romstage.h> diff --git a/src/mainboard/google/dedede/romstage.c b/src/mainboard/google/dedede/romstage.c index af79c80..db6f7db 100644 --- a/src/mainboard/google/dedede/romstage.c +++ b/src/mainboard/google/dedede/romstage.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/variants.h> #include <console/console.h>
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Maxim Polyakov (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)