Change in coreboot[master]: arch/x86/id.S: Fix building with clang - coreboot-gerrit

3 Oct 2021


      Attention is currently required from: Arthur Heymans.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51500 )
Change subject: arch/x86/id.S: Fix building with clang
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/id.S:
https://review.coreboot.org/c/coreboot/+/51500/comment/1b0648f9_989b593f 
PS1, Line 15: .long	0xffffffff - ver + 1		/* Reverse offset to the version */
            : .long	0xffffffff - vendor + 1		/* Reverse offset to the vendor id */
            : .long	0xffffffff - part + 1		/* Reverse offset to the part number */
This also builds for me with GCC (X86_32), so maybe we can use it unconditionally?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51500
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I930e7b96c4428bcb95ff1903e6a3e7679171ffee
Gerrit-Change-Number: 51500
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 03 Oct 2021 11:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment