Attention is currently required from: Andrey Pronin, Raul Rangel, Julius Werner, Yu-Ping Wu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59476 )
Change subject: src/security/vboot: Setup secure counter space in TPM NVRAM
......................................................................
Patch Set 1:
(1 comment)
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/59476/comment/a20c42f1_3d718fa4
PS1, Line 368: rv = tlcl_read(index, &value, SECURE_COUNTER_SIZE);
Oh okay, sorry, I should read things more closely before I talk like I knew things. […]
Yes, increment operation can be done in the first use. Trusted application in PSP has agreed and in fact preferred to do that. So I can remove the read + increment operations here and just define the space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59476
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I915fbdada60e242d911b748ad5dc28028de9b657
Gerrit-Change-Number: 59476
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Andrey Pronin
apronin@google.com
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 19 Nov 2021 17:18:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrey Pronin
apronin@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment