Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80569?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex/variants/deku: correct GPIO F19 and F20 configuration
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80569/comment/b0f1671f_511715ae :
PS2, Line 7: correct GPIO F19 and F20 configuration
Maybe:
Correct GPIO F19/F20 to not connected
https://review.coreboot.org/c/coreboot/+/80569/comment/c4dec3e8_5beb4237 :
PS2, Line 9: GPP_F19 and GPP_F20 were set incorrectly previously.
: Changed to not connected.
: This CL corrects these settings according to schematics.
Please do not wrap lines, just because the sentence ends.
This can be shortened:
GPP_F19 and GPP_F20 are set incorrectly. Change them to not connected according to schematics.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80569?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb6da1f8696f44cb47be3d1de83c55e62b12a9e9
Gerrit-Change-Number: 80569
Gerrit-PatchSet: 2
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Sat, 17 Feb 2024 04:41:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment