Attention is currently required from: Balaji Manigandan, Eric Lai, Karthik Ramasubramanian, Shelley Chen, Subrata Banik, Sumeet R.P..
Paul Menzel has posted comments on this change by Sumeet R.P.. ( https://review.coreboot.org/c/coreboot/+/83662?usp=email )
Change subject: mb/google/brox/variants/brox:remove PL4 value modification
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83662/comment/8208f60c_8882bee1?usp... :
PS3, Line 7: mb/google/brox/variants/brox:remove PL4 value modification
Please add a space after the colon (:).
https://review.coreboot.org/c/coreboot/+/83662/comment/9e0a11d2_8f87c169?usp... :
PS3, Line 9: Remove PL4 value modification based on PsysPL3 value.
Why?
https://review.coreboot.org/c/coreboot/+/83662/comment/d25dafd6_d36f10df?usp... :
PS3, Line 13: TEST=Built and boot on brox system
What difference can be seen?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83662?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic7fbc6386769aa9f76a8665a742c97dfd790fd1d
Gerrit-Change-Number: 83662
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R.P.
sumeet4linux@gmail.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Sumeet R.P.
sumeet4linux@gmail.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 09 Sep 2024 18:20:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No