Attention is currently required from: Shelley Chen, Subrata Banik, Matt DeVillier, Edward O'Callaghan, Angel Pons, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62970 )
Change subject: mb/google/hatch: split up hatch and puff baseboards
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
I like this, but it's a big change, let's let it bake a for just a bit
File src/mainboard/google/puff/Kconfig:
https://review.coreboot.org/c/coreboot/+/62970/comment/244045d4_41dcbf9c
PS2, Line 95: select GBB_FLAG_FORCE_DEV_SWITCH_ON
: select GBB_FLAG_FORCE_DEV_BOOT_USB
: select GBB_FLAG_FORCE_DEV_BOOT_ALTFW
nit: not alphabetized
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62970
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c7350f3afcff3ddefc6fa14054a3f9257568cd3
Gerrit-Change-Number: 62970
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 22 Mar 2022 19:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment