HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38441 )
Change subject: src/include: Fix typos ......................................................................
src/include: Fix typos
Change-Id: Ia8e6e5bd5ac2565263d81df8ca81d62436a3301f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/bootmem.h M src/include/device_tree.h M src/include/spd_ddr2.h M src/include/spi-generic.h M src/include/timer.h 5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/38441/1
diff --git a/src/include/bootmem.h b/src/include/bootmem.h index 53e2d0f..165f7da 100644 --- a/src/include/bootmem.h +++ b/src/include/bootmem.h @@ -38,7 +38,7 @@ BM_MEM_UNUSABLE, /* Unusable address space */ BM_MEM_VENDOR_RSVD, /* Vendor Reserved */ BM_MEM_OPENSBI, /* Risc-V OpenSBI */ - BM_MEM_BL31, /* Arm64 BL31 exectuable */ + BM_MEM_BL31, /* Arm64 BL31 executable */ BM_MEM_TABLE, /* Ram configuration tables are kept in */ /* Tags below this point are ignored for the OS table. */ BM_MEM_OS_CUTOFF = BM_MEM_TABLE, diff --git a/src/include/device_tree.h b/src/include/device_tree.h index 56a9361..30da803 100644 --- a/src/include/device_tree.h +++ b/src/include/device_tree.h @@ -117,7 +117,7 @@ void fdt_print_node(const void *blob, uint32_t offset); int fdt_skip_node(const void *blob, uint32_t offset);
-/* Read a flattened device tree into a heirarchical structure which refers to +/* Read a flattened device tree into a hierarchical structure which refers to the contents of the flattened tree in place. Modifying the flat tree invalidates the unflattened one. */ struct device_tree *fdt_unflatten(const void *blob); diff --git a/src/include/spd_ddr2.h b/src/include/spd_ddr2.h index 724c996..c5b2763 100644 --- a/src/include/spd_ddr2.h +++ b/src/include/spd_ddr2.h @@ -57,7 +57,7 @@ SDRAM device, it could be 0x4, 0x8, so address lines for that would be 2, and 3 */
-/* Number of Ranks bit [2:0], Package (bit4, 1 = stack, 0 = planr), +/* Number of Ranks bit [2:0], Package (bit4, 1 = stack, 0 = planar), * Height bit[7:5] */ #define SPD_MOD_ATTRIB_RANK 5 diff --git a/src/include/spi-generic.h b/src/include/spi-generic.h index c88dcb2..3022886 100644 --- a/src/include/spi-generic.h +++ b/src/include/spi-generic.h @@ -264,7 +264,7 @@ * din: Pointer to a string of bytes that will be filled in. * bytesin: How many bytes to read. * - * Note that din and dout are transferred simulataneously in a full duplex + * Note that din and dout are transferred simultaneously in a full duplex * transaction. The number of clocks within one transaction is calculated * as: MAX(bytesout*8, bytesin*8). * diff --git a/src/include/timer.h b/src/include/timer.h index 621b486..3560966 100644 --- a/src/include/timer.h +++ b/src/include/timer.h @@ -160,7 +160,7 @@ }
/* - * Tick and check the stopwatch for expiration. Returns non-zero on exipration. + * Tick and check the stopwatch for expiration. Returns non-zero on expiration. */ static inline int stopwatch_expired(struct stopwatch *sw) {
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38441
to look at the new patch set (#2).
Change subject: src/include: Fix typos ......................................................................
src/include: Fix typos
Change-Id: Ia8e6e5bd5ac2565263d81df8ca81d62436a3301f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/bootmem.h M src/include/console/post_codes.h M src/include/device_tree.h M src/include/spd_ddr2.h M src/include/spi-generic.h M src/include/timer.h 6 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/38441/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38441 )
Change subject: src/include: Fix typos ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38441 )
Change subject: src/include: Fix typos ......................................................................
src/include: Fix typos
Change-Id: Ia8e6e5bd5ac2565263d81df8ca81d62436a3301f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38441 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/include/bootmem.h M src/include/console/post_codes.h M src/include/device_tree.h M src/include/spd_ddr2.h M src/include/spi-generic.h M src/include/timer.h 6 files changed, 7 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/include/bootmem.h b/src/include/bootmem.h index 53e2d0f..165f7da 100644 --- a/src/include/bootmem.h +++ b/src/include/bootmem.h @@ -38,7 +38,7 @@ BM_MEM_UNUSABLE, /* Unusable address space */ BM_MEM_VENDOR_RSVD, /* Vendor Reserved */ BM_MEM_OPENSBI, /* Risc-V OpenSBI */ - BM_MEM_BL31, /* Arm64 BL31 exectuable */ + BM_MEM_BL31, /* Arm64 BL31 executable */ BM_MEM_TABLE, /* Ram configuration tables are kept in */ /* Tags below this point are ignored for the OS table. */ BM_MEM_OS_CUTOFF = BM_MEM_TABLE, diff --git a/src/include/console/post_codes.h b/src/include/console/post_codes.h index 1813c9e..9877a5e 100644 --- a/src/include/console/post_codes.h +++ b/src/include/console/post_codes.h @@ -156,7 +156,7 @@ #define POST_BS_DEV_ENUMERATE 0x72
/** - * \brief Device Resource Allocatio + * \brief Device Resource Allocation * * Boot State Machine: bs_dev_resources() */ @@ -365,7 +365,7 @@ /** * \brief TPM failure * - * An error with the TPM, either unexepcted state or communications failure. + * An error with the TPM, either unexpected state or communications failure. */ #define POST_TPM_FAILURE 0xed
diff --git a/src/include/device_tree.h b/src/include/device_tree.h index 56a9361..30da803 100644 --- a/src/include/device_tree.h +++ b/src/include/device_tree.h @@ -117,7 +117,7 @@ void fdt_print_node(const void *blob, uint32_t offset); int fdt_skip_node(const void *blob, uint32_t offset);
-/* Read a flattened device tree into a heirarchical structure which refers to +/* Read a flattened device tree into a hierarchical structure which refers to the contents of the flattened tree in place. Modifying the flat tree invalidates the unflattened one. */ struct device_tree *fdt_unflatten(const void *blob); diff --git a/src/include/spd_ddr2.h b/src/include/spd_ddr2.h index 724c996..c5b2763 100644 --- a/src/include/spd_ddr2.h +++ b/src/include/spd_ddr2.h @@ -57,7 +57,7 @@ SDRAM device, it could be 0x4, 0x8, so address lines for that would be 2, and 3 */
-/* Number of Ranks bit [2:0], Package (bit4, 1 = stack, 0 = planr), +/* Number of Ranks bit [2:0], Package (bit4, 1 = stack, 0 = planar), * Height bit[7:5] */ #define SPD_MOD_ATTRIB_RANK 5 diff --git a/src/include/spi-generic.h b/src/include/spi-generic.h index c88dcb2..3022886 100644 --- a/src/include/spi-generic.h +++ b/src/include/spi-generic.h @@ -264,7 +264,7 @@ * din: Pointer to a string of bytes that will be filled in. * bytesin: How many bytes to read. * - * Note that din and dout are transferred simulataneously in a full duplex + * Note that din and dout are transferred simultaneously in a full duplex * transaction. The number of clocks within one transaction is calculated * as: MAX(bytesout*8, bytesin*8). * diff --git a/src/include/timer.h b/src/include/timer.h index 621b486..3560966 100644 --- a/src/include/timer.h +++ b/src/include/timer.h @@ -160,7 +160,7 @@ }
/* - * Tick and check the stopwatch for expiration. Returns non-zero on exipration. + * Tick and check the stopwatch for expiration. Returns non-zero on expiration. */ static inline int stopwatch_expired(struct stopwatch *sw) {
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)