Change in coreboot[master]: soc/intel/../thermal: Add support for thermal config behind PMC device - coreboot-gerrit

15 Nov 2021


      Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59209 )
Change subject: soc/intel/../thermal: Add support for thermal config behind PMC device
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/thermal.h:
https://review.coreboot.org/c/coreboot/+/59209/comment/8002ad08_0e47ce31 
PS6, Line 6: #define PMC_PWRM_THERMAL_CTEN			0x150c /* Catastrophic Trip Point Enable */
...
nits: can we align the comment :p should be easier to read.
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59209
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c6ae72610da39fc18ff252c440d006e83c570a0
Gerrit-Change-Number: 59209
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 16:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment