Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38430 )
Change subject: mb/facebook/monolith: Add description to device 4.0 ......................................................................
mb/facebook/monolith: Add description to device 4.0
BUG=N/A TEST=build
Change-Id: Id7267aa6d4266bb7807fb3c25b5e2704c8d81df7 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38430/1
diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb index a5f5b54..e9fa2a14 100644 --- a/src/mainboard/facebook/monolith/devicetree.cb +++ b/src/mainboard/facebook/monolith/devicetree.cb @@ -223,7 +223,7 @@ device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device - device pci 04.0 on end # + device pci 04.0 on end # Thermal Subsystem device pci 08.0 on end # Gaussian Mixture Model device pci 14.0 on end # USB xHCI device pci 14.1 on end # USB xDCI (OTG)
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38430 )
Change subject: mb/facebook/monolith: Add description to device 4.0 ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38430 )
Change subject: mb/facebook/monolith: Add description to device 4.0 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38430/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38430/1//COMMIT_MSG@7 PS1, Line 7: Add description to device 4.0 Describe device 4.0 in devicetree
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38430
to look at the new patch set (#3).
Change subject: mb/facebook/monolith: Describe device 4.0 in devicetree ......................................................................
mb/facebook/monolith: Describe device 4.0 in devicetree
BUG=N/A TEST=build
Change-Id: Id7267aa6d4266bb7807fb3c25b5e2704c8d81df7 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38430/3
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38430 )
Change subject: mb/facebook/monolith: Describe device 4.0 in devicetree ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38430/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38430/1//COMMIT_MSG@7 PS1, Line 7: Add description to device 4.0
Describe device 4. […]
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38430 )
Change subject: mb/facebook/monolith: Describe device 4.0 in devicetree ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38430 )
Change subject: mb/facebook/monolith: Describe device 4.0 in devicetree ......................................................................
mb/facebook/monolith: Describe device 4.0 in devicetree
BUG=N/A TEST=build
Change-Id: Id7267aa6d4266bb7807fb3c25b5e2704c8d81df7 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38430 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb index a5f5b54..e9fa2a14 100644 --- a/src/mainboard/facebook/monolith/devicetree.cb +++ b/src/mainboard/facebook/monolith/devicetree.cb @@ -223,7 +223,7 @@ device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device - device pci 04.0 on end # + device pci 04.0 on end # Thermal Subsystem device pci 08.0 on end # Gaussian Mixture Model device pci 14.0 on end # USB xHCI device pci 14.1 on end # USB xDCI (OTG)
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)