Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Jamie Ryu, Lance Zhao, Subrata Banik, Tim Wawrzynczak.
Wonkyu Kim has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84230?usp=email )
Change subject: make same cpu pyhsical address
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84230/comment/296f6b7f_f3557c68?usp... :
PS2, Line 7: make same cpu pyhsical address
:
: 2 funtions are used to get cpu physical address like below.
: cpu_phys_address_size
: soc_phys_address_size
: And If CONFIG_SOC_PHYSICAL_ADDRESS_WIDTH is defined,
: it can return different address size like below
: example)
: coreboot log: CPU physical address size: 46 bits
: OS log : DMAR: Host address width 42
: So, need to make one API to use same physical address.
:
Yes, the return value is overrided by CONFIG_SOC_PHYSICAL_ADDRESS_WIDT only in soc_phys_address_size […]
This change still supports overriding address width like current implementation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84230?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I06c485511fa7f72a445c8aed56d8a470b4772092
Gerrit-Change-Number: 84230
Gerrit-PatchSet: 3
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Mon, 09 Sep 2024 18:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com