Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34089 )
Change subject: src/soc/intel/common/itss: Add support to get IRQ configuration for PCI devices
......................................................................
Patch Set 9: Code-Review-1
(2 comments)
There is already code + an API to do more or less what you want in southbridge/intel/common. Please reuse and extend that.
https://review.coreboot.org/c/coreboot/+/34089/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34089/9//COMMIT_MSG@13
PS9, Line 13: This table can then be used for FSP interrupt config override or generate
: acpi _PRT PIRx entry.
southbridge/intel/common/{acpi_pirq_gen.c,rcba_pirq.c} Does exactly that for older platforms. Could you simply reuse the same API and simply provide a intel_common_map_pirq implementation for your platform?
https://review.coreboot.org/c/coreboot/+/34089/9/src/soc/intel/common/block/...
File src/soc/intel/common/block/itss/irq.c:
https://review.coreboot.org/c/coreboot/+/34089/9/src/soc/intel/common/block/...
PS9, Line 78: uint8_t *irq_config
This API is bad. What if the caller does not allocate enough size? Why is it an uint8_t while it is actually a struct you use?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7066432ff5f0d7017ac5a44922ca69f07da9556
Gerrit-Change-Number: 34089
Gerrit-PatchSet: 9
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 22 Jul 2019 11:40:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment