Attention is currently required from: Felix Singer, Michał Kopeć, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 )
Change subject: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support ......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/clevo/tgl-u/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/62498/comment/a96be924_dc263ebb PS1, Line 5: select BOARD_CLEVO_NV4X_BASE
hmm, but that's exactly how it's done in clevo/cml-u/Kconfig{,. […]
I saw patches shifting these selects to the Kconfig.name to Kconfig files, e.g. CB:62816
Michał, let's apply it as well.
File src/mainboard/clevo/tgl-u/board.fmd:
PS1:
Why is this needed?
Nothing special here. All handled automatically by build system. Michał you can remove the file.
File src/mainboard/clevo/tgl-u/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62498/comment/f4c8adde_c245e156 PS1, Line 58: register "LpmStateDisableMask" = " : LPM_S0i2_1 | : LPM_S0i2_2 | : LPM_S0i3_1 | : LPM_S0i3_2 | : LPM_S0i3_3 | : LPM_S0i3_4 :
well, this is already covered in src/soc/intel/tigerlake/lpm. […]
Yes, but it does not handle the LPM_S0i2_1. We can remove the rest I believe
-
Michał Żygowski (Code Review)