Attention is currently required from: Matt DeVillier, Nick Vaccaro, Subrata Banik.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80556?usp=email )
Change subject: soc/intel/cannonlake: select SOC_INTEL_COMMON_BLOCK_DTT
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
note: there are other devices as well using CNL/CML SoC, which will now subscribe to the DTT common […]
`dtt.c` currently only hooks up scan_generic_bus(). Which shouldn't make
a difference when the device is disabled. OTOH, we need the select so the
parent change is effective.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80556?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I838ada7dfe948c58a5bb9805ade289b07368aa63
Gerrit-Change-Number: 80556
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 16 Feb 2024 12:03:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment