Attention is currently required from: Hsuan-ting Chen, Yu-Ping Wu.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76253?usp=email )
Change subject: tests/lib: Add unit tests for ux_locales_get_text()
......................................................................
Patch Set 16:
(1 comment)
File tests/lib/ux_locales-test.c:
https://review.coreboot.org/c/coreboot/+/76253/comment/625f0483_ac5e362a :
PS16, Line 201: Because of the design limitations of cmocka, using #_expect will cause build failure.
: This is because #_expect will cause the test name to have double quotes.
Unfortunately CMocka ToT is the same. […]
I can create PR and then migrate coreboot to new CMocka.
Anyway, @roccochen please fix what Yu-Ping pointed out, so we can close this thread.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76253?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d73419c02478870942828d324c258ef0eaa983c
Gerrit-Change-Number: 76253
Gerrit-PatchSet: 16
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 02 Aug 2023 11:44:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment