Attention is currently required from: Wonkyu Kim, Tim Wawrzynczak, Kyösti Mälkki, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58386 )
Change subject: cpu/x86/lapic: Unconditionally use CPUID leaf 0xb if available
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/c/coreboot/+/58386/comment/bff3b227_345619dd
PS4, Line 108: jc 1f
I always confuse these conditionals, jumps if eax < 0xb ?
JC, JB, JNAE = Jump if CF = 1
The code looks sane to me.
https://review.coreboot.org/c/coreboot/+/58386/comment/e8e673cc_d6d054ad
PS4, Line 124: cmp (%ebx, %ecx, 2), %ax
Does it make sense to optimise the table to 16bits of LAPIC ID?
This is an idea for a follow-up, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f1f46fe5091ebeab6dfb4c7e151150cf495d0cb
Gerrit-Change-Number: 58386
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 20 Dec 2021 10:43:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment