Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40006 )
Change subject: mb/google/ripto: Enable DMI/SATA power Optimize ......................................................................
mb/google/ripto: Enable DMI/SATA power Optimize
Turn on power optimizer of PCH side DMI and SATA controller.
BUG=N/A TEST=Build and boot up into ripto platform.
Change-Id: I179d83c3c75468ece263ccb3cde9f620ecb858cd Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/google/volteer/variants/ripto/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/40006/1
diff --git a/src/mainboard/google/volteer/variants/ripto/overridetree.cb b/src/mainboard/google/volteer/variants/ripto/overridetree.cb index 162f93b..3787b8e 100644 --- a/src/mainboard/google/volteer/variants/ripto/overridetree.cb +++ b/src/mainboard/google/volteer/variants/ripto/overridetree.cb @@ -5,6 +5,9 @@ register "PcieRpL1Substates[8]" = "2" register "PcieRpL1Substates[10]" = "2"
+ register "dmipwroptimize" = "1" + register "satapwroptimize" = "1" + device domain 0 on end
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40006 )
Change subject: mb/google/ripto: Enable DMI/SATA power Optimize ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG@7 PS1, Line 7: Optimize optimizer
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG@10 PS1, Line 10: Any measurement data, how much is saved?
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40006 )
Change subject: mb/google/ripto: Enable DMI/SATA power Optimize ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG@7 PS1, Line 7: Optimize
optimizer
Ack
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG@10 PS1, Line 10:
Any measurement data, how much is saved?
I am checking this with our pnp team. Did not got the exact number yet.
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Roy Mingi Park, Nick Vaccaro, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40006
to look at the new patch set (#2).
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer ......................................................................
mb/google/ripto: Enable DMI/SATA power Optimizer
Turn on power optimizer of PCH side DMI and SATA controller.
BUG=N/A TEST=Build and boot up into ripto platform.
Change-Id: I179d83c3c75468ece263ccb3cde9f620ecb858cd Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/google/volteer/variants/ripto/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/40006/2
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Roy Mingi Park, Nick Vaccaro, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40006
to look at the new patch set (#3).
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer ......................................................................
mb/google/ripto: Enable DMI/SATA power Optimizer
Turn on power optimizer of PCH side DMI and SATA controller.
BUG=b:151162424 BRANCH=None TEST=Build and boot up into ripto platform.
Change-Id: I179d83c3c75468ece263ccb3cde9f620ecb858cd Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/google/volteer/variants/ripto/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/40006/3
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40006 )
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer ......................................................................
Patch Set 3:
(1 comment)
@Roy, Do you have any data showing how much we are saving by enabling these setting?
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG@10 PS1, Line 10:
I am checking this with our pnp team. Did not got the exact number yet.
Ack
Roy Mingi Park has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40006 )
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40006/1//COMMIT_MSG@10 PS1, Line 10:
Ack
With those flags, SATA controller can go to low power state such as Dev Sleep. Upon entering Device Sleep, the Host and device may power down PLL's, clocks, and media in addition to the PHY interface. And average SATA power will be ~5mW. Without those flags, SATA power will be higher than 10mW as it can't go to Dev Sleep.
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Roy Mingi Park, Nick Vaccaro, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40006
to look at the new patch set (#5).
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer ......................................................................
mb/google/ripto: Enable DMI/SATA power Optimizer
Turn on power optimizer of PCH side DMI and SATA controller.
BUG=b:151162424 BRANCH=None TEST=Build and boot up into ripto platform.
Change-Id: I179d83c3c75468ece263ccb3cde9f620ecb858cd Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/google/volteer/variants/ripto/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/40006/5
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Roy Mingi Park, Duncan Laurie, Nick Vaccaro, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40006
to look at the new patch set (#6).
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer ......................................................................
mb/google/ripto: Enable DMI/SATA power Optimizer
Turn on power optimizer of PCH side DMI and SATA controller.
BUG=b:151162424 BRANCH=None TEST=Build and boot up into ripto platform.
Change-Id: I179d83c3c75468ece263ccb3cde9f620ecb858cd Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/google/volteer/variants/ripto/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/40006/6
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40006 )
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer ......................................................................
Patch Set 6: Code-Review-1
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40006 )
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40006/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40006/6//COMMIT_MSG@7 PS6, Line 7: O lower-case "o"
https://review.coreboot.org/c/coreboot/+/40006/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/ripto/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40006/6/src/mainboard/google/voltee... PS6, Line 8: DmiPwrOptimizeDisable" = "1" Given the change in variable name and functionality, PwrOptimize is now enabled by default. This patchset's commit message states that the purpose of this patch is to enable PwrOptimize. Given that is now default behavior, this patch is no longer required, correct?
Or if intent of this patch is to disable the power optimizer, then please change the commit message to indicate such. Thanks.
Shaunak Saha has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40006 )
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer ......................................................................
Abandoned
-
Nick Vaccaro (Code Review) -
Paul Menzel (Code Review)
-
Roy Mingi Park (Code Review)
-
Shaunak Saha (Code Review)