Attention is currently required from: Ashish Kumar Mishra, Caveh Jalali, Dinesh Gehlot, Eric Herrmann, Forest Mittelberg, Jayvik Desai, Karthik Ramasubramanian, Keith Short, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Rishika Raj, Ronak Kanabar, Shelley Chen, Sowmya Aralguppe, Subrata Banik.
Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83752?usp=email )
Change subject: mb/google/brox: Fix booting to kernel without battery
......................................................................
Patch Set 24:
(1 comment)
File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83752/comment/1afeb40b_f0db7709?usp... :
PS19, Line 57: * PL4 calculations - For USB C charger (Max Power):
Got it - my experiments were with pl4 = 19 and pl4 = 23 for 65 watts adaptors and the observations w […]
subrata >>>if we know that OS can override the PL4 table dynamically and we only need to set a lower P4 when battery is not present. Then, it would be good to boot with a static configuration which is safest and generically applicable.
Adding logic to configure PL4 based on USB-PD capacity seems overdoing for BIOS.
Done - PL4 value is static = 9 watts (30W * 32%)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83752?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I58e136c607ea9290ecac0cee453d6632760a6433
Gerrit-Change-Number: 83752
Gerrit-PatchSet: 24
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Herrmann
eherrmann@google.com
Gerrit-Reviewer: Forest Mittelberg
bmbm@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Short
keithshort@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-CC: Dengwu Yu
yudengwu@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-CC: Sowmya Aralguppe
sowmya.aralguppe@intel.corp-partner.google.com
Gerrit-CC: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Eric Herrmann
eherrmann@google.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Keith Short
keithshort@google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Forest Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Wed, 11 Sep 2024 08:43:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sowmya Aralguppe
sowmya.aralguppe@intel.corp-partner.google.com
Comment-In-Reply-To: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com