Attention is currently required from: Tim Wawrzynczak, Amanda Hwang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63709 )
Change subject: mb/google/brya/var/brya0: Swap TPM and touchscreen I2C bus ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/brya0/gpio.c:
https://review.coreboot.org/c/coreboot/+/63709/comment/e54b39bb_82fd1ca9 PS1, Line 132: /* : * D1 : ISH_GP1 ==> FP_RST_ODL : * FP_RST_ODL comes out of reset as hi-z and does not have an external pull-down. : * To ensure proper power sequencing for the FPMCU device, reset signal is driven low : * early on in bootblock, followed by enabling of power. Reset signal is deasserted : * later on in ramstage. Since reset signal is asserted in bootblock, it results in : * FPMCU not working after a S3 resume. This is a known issue. : */ Please wrap the lines earlier, and also follow the [commenting style](https://doc.coreboot.org/contributing/coding_style.html#commenting).