build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39995 )
Change subject: mb/siemens/chili: Add Chili variant ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39995/13/src/mainboard/siemens/chil... File src/mainboard/siemens/chili/romstage.c:
https://review.coreboot.org/c/coreboot/+/39995/13/src/mainboard/siemens/chil... PS13, Line 50: __weak void variant_romstage_params(FSPM_UPD *const mupd) need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/39995/13/src/mainboard/siemens/chil... File src/mainboard/siemens/chili/variants/chili/gpio.c:
https://review.coreboot.org/c/coreboot/+/39995/13/src/mainboard/siemens/chil... PS13, Line 44: /* GPP_G3 GPIO 0x0000006f40880102 */ PAD_CFG_GPI_APIC(GPP_G3, NONE, DEEP, LEVEL, INVERT), line over 96 characters
https://review.coreboot.org/c/coreboot/+/39995/13/src/mainboard/siemens/chil... PS13, Line 49: /* GPD7 GPIO 0x0000006704000200 */ PAD_NC(GPD7, DN_20K), /* unused, formerly USB always on */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39995/13/src/mainboard/siemens/chil... PS13, Line 95: /* GPP_F18 GPIO 0x0000004240880102 */ PAD_CFG_GPI_APIC(GPP_F18, NONE, DEEP, LEVEL, INVERT), line over 96 characters
-
build bot (Jenkins) (Code Review)