Change in ...coreboot[master]: mb/google/hatch: Initialize GPIO_PCH_WP early in boot

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Rizwan Qureshi (Code Review)

24 Feb 2019 24 Feb '19

8 p.m.

Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31599

Change subject: mb/google/hatch: Initialize GPIO_PCH_WP early in boot ......................................................................

mb/google/hatch: Initialize GPIO_PCH_WP early in boot

Initialize GPIO_PCH_WP early in boot. Also update the cros_gpios[] array with GPIO_PCH_WP information.

Change-Id: I0b7e6dbf9229941aca4952965fb54f07457dccae Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/31599/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index e1189b9..b4130c8 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -209,6 +209,8 @@ PAD_CFG_GPI_APIC(GPP_C21, NONE, DEEP, LEVEL, NONE), /* WLAN_PE_RST# */ PAD_CFG_GPO(GPP_C23, 1, DEEP), + /* PCH_WP_OD */ + PAD_CFG_GPI(GPP_C20, NONE, DEEP), };

const struct pad_config *__weak variant_early_gpio_table(size_t *num) @@ -218,6 +220,8 @@ }

static const struct cros_gpio cros_gpios[] = { + CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), + CROS_GPIO_WP_AH(GPIO_PCH_WP, CROS_GPIO_DEVICE_NAME), };

const struct cros_gpio *__weak variant_cros_gpios(size_t *num)

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Furquan Shaikh (Code Review)

25 Feb 25 Feb

12:28 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31599 )

Change subject: mb/google/hatch: Initialize GPIO_PCH_WP early in boot ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/31599/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31599/3/src/mainboard/google/hatch/variants/... PS3, Line 212: /* PCH_WP_OD */ : PAD_CFG_GPI(GPP_C20, NONE, DEEP), Can you please place this before GPP_C21?

Also, this should be placed in gpio_table as well.

https://review.coreboot.org/#/c/31599/3/src/mainboard/google/hatch/variants/... PS3, Line 223: CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), There is no mention in commit message of this change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b7e6dbf9229941aca4952965fb54f07457dccae Gerrit-Change-Number: 31599 Gerrit-PatchSet: 3 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 25 Feb 2019 03:28:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

2:58 p.m.

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31599

to look at the new patch set (#4).

Change subject: mb/google/hatch: Initialize GPIO_PCH_WP early in boot ......................................................................

mb/google/hatch: Initialize GPIO_PCH_WP early in boot

Initialize GPIO_PCH_WP early in boot. Update cros_gpios[] array with GPIO_PCH_WP information. Also, Configure recovery mode GPIO as virtual since hatch does not have one.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/31599/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/31599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b7e6dbf9229941aca4952965fb54f07457dccae Gerrit-Change-Number: 31599 Gerrit-PatchSet: 4 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Rizwan Qureshi (Code Review)

2:59 p.m.

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31599 )

Change subject: mb/google/hatch: Initialize GPIO_PCH_WP early in boot ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/31599/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31599/3/src/mainboard/google/hatch/variants/... PS3, Line 212: /* PCH_WP_OD */ : PAD_CFG_GPI(GPP_C20, NONE, DEEP),

...

Can you please place this before GPP_C21? […]

Done

https://review.coreboot.org/#/c/31599/3/src/mainboard/google/hatch/variants/... PS3, Line 223: CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),

...

There is no mention in commit message of this change.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/31599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b7e6dbf9229941aca4952965fb54f07457dccae Gerrit-Change-Number: 31599 Gerrit-PatchSet: 4 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 25 Feb 2019 05:59:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

3:01 p.m.

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31599

to look at the new patch set (#5).

Change subject: mb/google/hatch: Initialize GPIO_PCH_WP early in boot ......................................................................

mb/google/hatch: Initialize GPIO_PCH_WP early in boot

Initialize GPIO_PCH_WP early in boot. Update cros_gpios[] array with GPIO_PCH_WP information. Also, Configure recovery mode GPIO as virtual since hatch does not have one.

BUG=b:125943273

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/31599/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/31599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b7e6dbf9229941aca4952965fb54f07457dccae Gerrit-Change-Number: 31599 Gerrit-PatchSet: 5 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

26 Feb 26 Feb

6:02 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31599 )

Change subject: mb/google/hatch: Initialize GPIO_PCH_WP early in boot ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b7e6dbf9229941aca4952965fb54f07457dccae Gerrit-Change-Number: 31599 Gerrit-PatchSet: 5 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 25 Feb 2019 21:02:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

27 Feb 27 Feb

8:05 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31599 )

Change subject: mb/google/hatch: Initialize GPIO_PCH_WP early in boot ......................................................................

mb/google/hatch: Initialize GPIO_PCH_WP early in boot

Initialize GPIO_PCH_WP early in boot. Update cros_gpios[] array with GPIO_PCH_WP information. Also, Configure recovery mode GPIO as virtual since hatch does not have one.

BUG=b:125943273

Change-Id: I0b7e6dbf9229941aca4952965fb54f07457dccae Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Reviewed-on: https://review.coreboot.org/c/31599 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 4 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index e1189b9..b88f459 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -201,6 +201,8 @@ PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1), /* H1_SLAVE_SPI_MOSI_R */ PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1), + /* PCH_WP_OD */ + PAD_CFG_GPI(GPP_C20, NONE, DEEP), /* * H1_PCH_INT_ODL * TODO Configure it back to invert mode, when @@ -218,6 +220,8 @@ }

static const struct cros_gpio cros_gpios[] = { + CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), + CROS_GPIO_WP_AH(GPIO_PCH_WP, CROS_GPIO_DEVICE_NAME), };

const struct cros_gpio *__weak variant_cros_gpios(size_t *num)

-- To view, visit https://review.coreboot.org/c/coreboot/+/31599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b7e6dbf9229941aca4952965fb54f07457dccae Gerrit-Change-Number: 31599 Gerrit-PatchSet: 13 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2048

days inactive

2051

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Rizwan Qureshi (Code Review)