Attention is currently required from: Felix Singer, Edward O'Callaghan. Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62808 )
Change subject: mb/hp/z220_series: Convert z220_sff_workstation into variant ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62808/comment/dc99fed7_90e4ec15 PS1, Line 7: hp/z220_series: Convert z220_sff_workstation into variant
mb/hp/z220_series: ...
Done
https://review.coreboot.org/c/coreboot/+/62808/comment/8bc40e26_c08dec0c PS1, Line 11: $ diff static.c ~/static.c.orig
Please build with BUILD_TIMELESS=1 and with `INCLUDE_CONFIG_FILE` (General setup -> Include the core […]
Done
Patchset:
PS2: Thanks for review.
File src/mainboard/hp/z220_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/62808/comment/5080ffb1_8acdec76 PS1, Line 1: BOARD_HP_Z220_SERIES
It's not strictly required, but the _COMMON suffix is an indication for the reader that it serves as […]
Done
File src/mainboard/hp/z220_series/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/62808/comment/bf2213e6_037378b9 PS1, Line 3: select BOARD_HP_Z220_SERIES
Thanks for pointing me to mb/hp/snb_ivb_laptops. I have just reworked it in CB:62816. […]
Ack