Attention is currently required from: Wonkyu Kim, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Patrick Rudolph.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60989 )
Change subject: soc/intel: Abstract the common block API for TCSS registers access
......................................................................
Patch Set 6:
(3 comments)
File src/soc/intel/common/block/tcss/Kconfig:
https://review.coreboot.org/c/coreboot/+/60989/comment/dadc23f1_231779a2
PS6, Line 17: Alde
nit: Alder Lake
Ack
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/60989/comment/127b7e34_09ff540c
PS4, Line 376: #if CONFIG(TCSS_REG_ACCESS_REGBAR)
Please avoid using #if/#else
It turns out the "#if" evaluated at compiler time works to handle multiple platforms. Compiler errors occur if using the term "if" here.
https://review.coreboot.org/c/coreboot/+/60989/comment/c953c132_d08de61d
PS4, Line 378: #else
same
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60989
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e2696b117af24412d73b257f470efc40caa5022
Gerrit-Change-Number: 60989
Gerrit-PatchSet: 6
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 15 Jan 2022 19:41:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Gerrit-MessageType: comment