Attention is currently required from: Felix Singer, Subrata Banik, Tim Wawrzynczak, Patrick Rudolph, EricR Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60406 )
Change subject: soc/intel/alderlake: Skip FSP Notify APIs
......................................................................
Patch Set 21: Code-Review+1
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/60406/comment/ea704c9b_11c13662
PS21, Line 360:
: config USE_COREBOOT_NATIVE_END_OF_POST_DRIVER
: bool
: default y
: select SKIP_FSP_NOTIFY_PHASE_READY_TO_BOOT
: select SKIP_FSP_NOTIFY_PHASE_END_OF_FIRMWARE
:
I would skip this and just select the two SKIP Kconfigs
Unless there's a reason to change this, I'd also drop the Kconfig. If it's meant to be overriden through site-local, I'd document it as help text.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60406
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0198c9568de0e74053775682a44324405746389a
Gerrit-Change-Number: 60406
Gerrit-PatchSet: 21
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 09 Feb 2022 21:11:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment