Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73897 )
Change subject: mb/google/brya/acpi: Correct _DSM GPS function for revision check ......................................................................
mb/google/brya/acpi: Correct _DSM GPS function for revision check
The logic was not equals, rather than the intended greater than or equal to for checking the minimum GPS revision.
TEST=version check passes as expected now BUG=b:271938907 Signed-off-by: Tarun Tuli taruntuli@google.com Change-Id: I66bf1fc32295e1b9e9c41c661ea8e395a1592a86 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73897 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/mainboard/google/brya/acpi/gpu_top.asl 1 file changed, 19 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/acpi/gpu_top.asl b/src/mainboard/google/brya/acpi/gpu_top.asl index c98358f..e23e3cf 100644 --- a/src/mainboard/google/brya/acpi/gpu_top.asl +++ b/src/mainboard/google/brya/acpi/gpu_top.asl @@ -85,7 +85,7 @@ } ElseIf (Arg0 == ToUUID (UUID_GPS)) { - If (ToInteger (Arg1) != REVISION_MIN_GPS) + If (ToInteger (Arg1) >= REVISION_MIN_GPS) { Return (GPS (Arg2, Arg3)) }