[L] Change in coreboot[master]: mb/{skl,kbl}: Use true/false keywords for non-array dt options

[Felix Singer (Code Review)]

Attention is currently required from: Angel Pons, Frans Hendriks, Jeremy Soller, Michael Niewöhner, Michał Żygowski, Nico Huber, Piotr Król, Sean Rhodes, Tim Crawford.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75888?usp=email )

Change subject: mb/{skl,kbl}: Use true/false keywords for non-array dt options
......................................................................

Patch Set 5:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/75888/comment/8ab9621f_7d8cf245 :
PS5, Line 25:     soc_gen="skylake" && \
            :     options=`grep -A 1337 -r "struct soc_intel_${soc_gen}_config" "src/soc/intel/${soc_gen}/chip.h" | \
            :         grep "bool" | \
            :         cut -d ';' -f 1 | \
            :         tr '\t' ' ' | \
            :         cut -d ' ' -f 3 | \
            :         sed -E 's/[a-zA-Z0-9_]+[.+]//g'`
            :     devicetrees=`find "src/mainboard" -name '*.cb' \
            :         -exec grep -H "chip soc/intel/${soc_gen}" {} ; | \
            :         cut -d ':' -f 1` && \
            :     for option in ${options}; do \
            :         echo ${devicetrees} | \
            :         xargs sed -i'' -E \
            :             -e "s/"${option}"(\s+)=(\s+)"1"/${option}\1=\2true/g" \
            :             -e "s/"${option}"(\s+)=(\s+)"0"/${option}\1=\2false/g"; \
            :     done
            :
> opinions?

Didn't have time to look at your proposal yet, but I will definitely look. Thanks for your review! 😊