Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69217 )
Change subject: soc/intel/alderlake: Set PL1 Time to Intel default 56s for certain CPUs ......................................................................
soc/intel/alderlake: Set PL1 Time to Intel default 56s for certain CPUs
Mobile SKUs with TDP equal to 45W should have PL1 Time equal 56 seconds. Desktop ADL-S SKUs with TDP 125W or higher also default to 56 seconds of PL1 Time.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I02c56b981d956bef58ae90f7f317a231416a2e54 --- M src/soc/intel/alderlake/systemagent.c M src/soc/intel/common/block/include/intelblocks/power_limit.h 2 files changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/69217/1
diff --git a/src/soc/intel/alderlake/systemagent.c b/src/soc/intel/alderlake/systemagent.c index 9a8532d..2ee578f 100644 --- a/src/soc/intel/alderlake/systemagent.c +++ b/src/soc/intel/alderlake/systemagent.c @@ -183,7 +183,10 @@ if (sa_pci_id == cpuid_to_adl[i].cpu_id && tdp == cpuid_to_adl[i].cpu_tdp) { soc_config = &config->power_limits_config[cpuid_to_adl[i].limits]; - set_power_limits(MOBILE_SKU_PL1_TIME_SEC, soc_config); + if (tdp >= TDP_125W) + set_power_limits(DESKTOP_SKU_PL1_TIME_SEC, soc_config); + else + set_power_limits(MOBILE_SKU_PL1_TIME_SEC, soc_config); break; } } diff --git a/src/soc/intel/common/block/include/intelblocks/power_limit.h b/src/soc/intel/common/block/include/intelblocks/power_limit.h index 3f18126..f07c8ef 100644 --- a/src/soc/intel/common/block/include/intelblocks/power_limit.h +++ b/src/soc/intel/common/block/include/intelblocks/power_limit.h @@ -14,6 +14,7 @@
/* Default power limit value in secs */ #define MOBILE_SKU_PL1_TIME_SEC 28 +#define DESKTOP_SKU_PL1_TIME_SEC 56
#define MILLIWATTS_TO_WATTS 1000