Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85581?usp=email )
Change subject: mb/trulo/var/uldrenite: Configuration serial_io and I2C
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85581/comment/b3aa23cb_834265f3?usp... :
PS4, Line 7: Configuration
Please use a verb (in imperative mood): Configure
https://review.coreboot.org/c/coreboot/+/85581/comment/2c8564c2_8c49f4ec?usp... :
PS4, Line 9: Configuration
Configure
File src/mainboard/google/brya/variants/uldrenite/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85581/comment/f3d065ff_b469ce24?usp... :
PS4, Line 112: .scl_lcnt = 55,
: .scl_hcnt = 30,
: .sda_hold = 7,
: }
: },
: .i2c[1] = {
: .speed = I2C_SPEED_FAST,
: .speed_config[0] = {
: .speed = I2C_SPEED_FAST,
: .scl_lcnt = 158,
: .scl_hcnt = 79,
: .sda_hold = 7,
: }
: },
: .i2c[5] = {
: .speed = I2C_SPEED_FAST,
: .speed_config[0] = {
: .speed = I2C_SPEED_FAST,
: .scl_lcnt = 158,
: .scl_hcnt = 79,
: .sda_hold = 7,
Where are the values from?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85581?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3c1b6028c7e4392a2142851d5fd0199954e2272d
Gerrit-Change-Number: 85581
Gerrit-PatchSet: 4
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Sun, 15 Dec 2024 19:44:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No