Attention is currently required from: Arthur Heymans, Eric Lai, Paul Menzel, Subrata Banik, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75756?usp=email )
Change subject: arch/x86: Introduce DUMP_SMBIOS_TYPE17 config ......................................................................
Patch Set 10:
(3 comments)
File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/75756/comment/b2a2ccc6_f48b3f49 : PS9, Line 362: choice : prompt "Dump SMBIOS type17" : default n : depends on GENERATE_SMBIOS_TABLES
drop the choice.
Done
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/75756/comment/0b76c691_4764d7da : PS9, Line 226: /* skip old type for save static memory : "Other", : "Unknown", : "DRAM", : "EDRAM", : "VRAM", : "SRAM", : "RAM", : "ROM", : "Flash", : "EEPROM", : "FEPROM", : "EPROM", : "CDRAM", : "3DRAM", : "SDRAM", : "SGRAM", : "RDRAM", : "DDR", : "DDR2", : "DDR2 FB-DIMM", : "Reserved", : "Reserved", : "Reserved", : "DDR3", : "FBD2", : */
oh because I think we don't need it. Since it's too old. […]
I change the wording.
https://review.coreboot.org/c/coreboot/+/75756/comment/2a0d5eb8_a0584e47 : PS9, Line 265: 0x1A
oh yes. […]
Done