Attention is currently required from: Sam McNally, Furquan Shaikh, Tim Wawrzynczak, Edward O'Callaghan, Keith Tzeng, Wisley Chen.
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52725 )
Change subject: mb/google/puff/var/dooly: enable touchscreen wakeup
......................................................................
Patch Set 10:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52725/comment/6ed814f0_4305951a
PS9, Line 11: Add fake touchscreen enable_pin GPP_D9 to ensure meet power sequence T11 in spec v0.8.
How? What is spec v0. […]
Keep current setting, just add wake source.
Thanks
https://review.coreboot.org/c/coreboot/+/52725/comment/f2824771_57943ea6
PS9, Line 13: empty pin
when you say "empty" do you mean NC or do you mean GND plane? I assume you mean NC but I wanted to c […]
Yes, GPP_D9 is NC ping on dooly board.
Thanks
Patchset:
PS10:
Please help review.
Thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Gerrit-Change-Number: 52725
Gerrit-PatchSet: 10
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 05 May 2021 01:11:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment